Fixing broken exception handling after GAX 0.13.0 upgrade. by dhermes · Pull Request #2336 · googleapis/google-cloud-python

dhermes · 2016-09-16T18:34:25Z

~~This PR is currently incomplete (hence the "don't merge").~~

I wanted @bjwatson @geigerj et al to see what fix was needed.

This may be broken from googleapis/gax-python#127 or this may be the intended behavior.

I filed googleapis/gax-python#129 and googleapis/gax-python#130 as well

Sign in to view

 from google.logging.v2.log_entry_pb2 import LogEntry
 from google.protobuf.json_format import Parse
 from grpc import StatusCode
+from grpc._channel import _Rendezvous


Sign in to view

 channel = None
 if connection.in_emulator:
- channel = insecure_channel(connection.host, None)
+ channel = insecure_channel(connection.host)


tseaver · 2016-09-16T22:20:13Z

@dhermes do we need to push this through to get green, and then work on resolving the issue with GaxError / _Rendezvous?

dhermes · 2016-09-16T22:49:13Z

That's fine with me. Definitely need to make sure @bjwatson and @geigerj are aware of what has broken

bjwatson · 2016-09-17T18:51:52Z

Thanks @dhermes and @tseaver. @geigerj and I will look into googleapis/gax-python#130 on Monday. IIUC, this does not block the 0.19.0 release, correct?

dhermes · 2016-09-17T18:52:55Z

@bjwatson It won't block us from releasing, but it's likely something you'll want to deal with ASAP (but in parallel, not in serial).

tseaver · 2016-09-18T14:38:24Z

@dhermes Let's go ahead and ~~merge~~ make the alias, and let #2156 be where we track the issue about using _Rendezvous.

bjwatson · 2016-09-19T14:55:48Z

@dhermes Agreed. Thanks.

Relates to googleapis#2156.

dhermes · 2016-09-19T16:13:52Z

@tseaver PTAL. I added a standalone commit for the rename. Let's get this merged ASAP.

I also realized _Rendezvous is used as a non-exception when stream type responses come back from gRPC.

dhermes · 2016-09-19T16:43:37Z

Hoping to go green finally:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/161085138

daspecster · 2016-09-19T16:54:49Z

@dhermes some failures :(
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/161085138#L1238-L1283

daspecster · 2016-09-19T16:58:30Z

It's almost like Logging got turned off or is having an outage?

dhermes · 2016-09-19T16:58:57Z

Do they work locally for you?

daspecster · 2016-09-19T16:59:59Z

I haven't tried but I'll do that right now.

daspecster · 2016-09-19T17:07:39Z

Nope doesn't work for me either.
I ran $ tox -e system-tests -- logging

Update: I may not have some permissions right...checking...

dhermes · 2016-09-19T17:12:35Z

Yeah I think that's the problem. @tseaver Can you check out https://console.cloud.google.com/apis/credentials?project=precise-truck-742 and make sure everything is in order permissions wise? (We recently have a new JSON keyfile on Travis since the old one didn't have the project ID in the JSON. #2292 added this change)

daspecster · 2016-09-19T17:20:21Z

I got mine working, it was the permissions.

With regards to the console link you sent...I don't have permissions for that project.

The place to update it would be https://console.cloud.google.com/iam-admin/iam/project?project=precise-truck-742, at least for me that's where it was.

dhermes · 2016-09-19T17:23:58Z

I don't have permissions for that project.

Wasn't sure if you did, hence: "@tseaver Can you check out"

daspecster · 2016-09-19T17:25:57Z

Sorry, thought I'd give it a go since it took me some hunting and pecking in the UI.

dhermes · 2016-09-19T17:50:22Z

Sorry, thought I'd give it a go since it took me some hunting and pecking in the UI.

No worries. Thanks for trying.

dhermes · 2016-09-19T18:10:46Z

I just used that exact key locally and had no issues:

TRAVIS_BUILD_ID=161085138 tox -e system-tests -- logging

I restarted https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/161085138, hopefully it will go green

dhermes · 2016-09-19T18:21:28Z

tox -e system-tests has passed already on the rebuild, hopefully system-tests3 will follow. w00t

dhermes · 2016-09-19T18:26:36Z

w00t. Green!

In the process, adding back code changes that were reverted in the process of reverting PR googleapis#2336. Some of the changes were necessary, but anything using GAX (logging and pubsub) could safely be restored.

* Tables Notebooks [(#2090)](GoogleCloudPlatform/python-docs-samples#2090) * initial commit * update census * update notebooks * remove the reference to a bug [(#2100)](GoogleCloudPlatform/python-docs-samples#2100) as the bug has been fixed in the public client lib * delete this file. [(#2102)](GoogleCloudPlatform/python-docs-samples#2102) * rename file name [(#2103)](GoogleCloudPlatform/python-docs-samples#2103) * trying to fix images [(#2101)](GoogleCloudPlatform/python-docs-samples#2101) * remove typo in installation [(#2110)](GoogleCloudPlatform/python-docs-samples#2110) * Rename census_income_prediction.ipynb to getting_started_notebook.ipynb [(#2115)](GoogleCloudPlatform/python-docs-samples#2115) renaming the notebooks as Getting Started (will be in sync with the doc). It will be great if the folder could be renamed too * added back missing file package import [(#2150)](GoogleCloudPlatform/python-docs-samples#2150) * added back missing file import [(#2145)](GoogleCloudPlatform/python-docs-samples#2145) * remove incorrect reference to Iris dataset [(#2203)](GoogleCloudPlatform/python-docs-samples#2203) * conversion to jupyter/colab [(#2340)](GoogleCloudPlatform/python-docs-samples#2340) plus bug fixes * updated for the Jupyter support [(#2337)](GoogleCloudPlatform/python-docs-samples#2337) * updated readme for support Jupyter [(#2336)](GoogleCloudPlatform/python-docs-samples#2336) to approve with the updated notebook supporting jupyter * conversion to jupyer/colab [(#2339)](GoogleCloudPlatform/python-docs-samples#2339) plus bug fixes * conversion of notebook for jupyter/Colab [(#2338)](GoogleCloudPlatform/python-docs-samples#2338) conversion of the notebook to support both Jupyter and Colab + bug fixes * [BLOCKED] AutoML Tables: Docs samples updated to use new (pending) client [(#2276)](GoogleCloudPlatform/python-docs-samples#2276) * AutoML Tables: Docs samples updated to use new (pending) client * Linter warnings * add product recommendation for automl tables notebook [(#2257)](GoogleCloudPlatform/python-docs-samples#2257) * added colab filtering notebook * update to tables client * update readme * tell user to restart kernel for automl * AutoML Tables: Notebook samples updated to use new tables client [(#2424)](GoogleCloudPlatform/python-docs-samples#2424) * fix users bug and emphasize kernal restart [(#2407)](GoogleCloudPlatform/python-docs-samples#2407) * fix problems with automl docs [(#2501)](GoogleCloudPlatform/python-docs-samples#2501) Today when we try to use the function `batch_predict` follow the docs we receive and error saying: `the paramaters should be a pandas.Dataframe` it’s happens because the first parameter of the function `batch_predict` is a pandas.Dataframe. To solve this problem we need to use de named parameters of python. * Fix typo in GCS URI parameter [(#2459)](GoogleCloudPlatform/python-docs-samples#2459) * fix: fix tables notebook links and bugs [(#2601)](GoogleCloudPlatform/python-docs-samples#2601) * feat(tables): update samples to show explainability [(#2523)](GoogleCloudPlatform/python-docs-samples#2523) * show xai * local feature importance * use updated client * use fixed library * use new model * Auto-update dependencies. [(#2005)](GoogleCloudPlatform/python-docs-samples#2005) * Auto-update dependencies. * Revert update of appengine/flexible/datastore. * revert update of appengine/flexible/scipy * revert update of bigquery/bqml * revert update of bigquery/cloud-client * revert update of bigquery/datalab-migration * revert update of bigtable/quickstart * revert update of compute/api * revert update of container_registry/container_analysis * revert update of dataflow/run_template * revert update of datastore/cloud-ndb * revert update of dialogflow/cloud-client * revert update of dlp * revert update of functions/imagemagick * revert update of functions/ocr/app * revert update of healthcare/api-client/fhir * revert update of iam/api-client * revert update of iot/api-client/gcs_file_to_device * revert update of iot/api-client/mqtt_example * revert update of language/automl * revert update of run/image-processing * revert update of vision/automl * revert update testing/requirements.txt * revert update of vision/cloud-client/detect * revert update of vision/cloud-client/product_search * revert update of jobs/v2/api_client * revert update of jobs/v3/api_client * revert update of opencensus * revert update of translate/cloud-client * revert update to speech/cloud-client Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> Co-authored-by: Doug Mahugh <dmahugh@gmail.com> * Update dependency google-cloud-automl to v0.10.0 [(#3033)](GoogleCloudPlatform/python-docs-samples#3033) Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> * Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-samples#2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: some lint fixes [(#3750)](GoogleCloudPlatform/python-docs-samples#3750) * automl: tables code sample clean-up [(#3571)](GoogleCloudPlatform/python-docs-samples#3571) * delete unused tables_dataset samples * delete args code associated with unused automl_tables samples * delete tests associated with unused automl_tables samples * restore get_dataset method/yargs without region tagging * Restore update_dataset methodsa without region tagging Co-authored-by: Takashi Matsuo <tmatsuo@google.com> Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> * add example of creating AutoML Tables client with non-default endpoint ('new' sdk) [(#3929)](GoogleCloudPlatform/python-docs-samples#3929) * add example of creating client with non-default endpoint * more test file cleanup * move connectivity print stmt out of test fn Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> Co-authored-by: Torry Yang <sirtorry@users.noreply.github.com> * Replace GCLOUD_PROJECT with GOOGLE_CLOUD_PROJECT. [(#4022)](GoogleCloudPlatform/python-docs-samples#4022) * chore(deps): update dependency google-cloud-automl to v1 [(#4127)](GoogleCloudPlatform/python-docs-samples#4127) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-cloud-automl](https://togithub.com/googleapis/python-automl) | major | `==0.10.0` -> `==1.0.1` | --- ### Release Notes <details> <summary>googleapis/python-automl</summary> ### [`v1.0.1`](https://togithub.com/googleapis/python-automl/blob/master/CHANGELOG.md#101-httpswwwgithubcomgoogleapispython-automlcomparev100v101-2020-06-18) [Compare Source](https://togithub.com/googleapis/python-automl/compare/v0.10.0...v1.0.1) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * [tables/automl] fix: update the csv file and the dataset name [(#4188)](GoogleCloudPlatform/python-docs-samples#4188) fixes#4177fixes#4178 * samples: Automl table batch test [(#4267)](GoogleCloudPlatform/python-docs-samples#4267) * added rtest req.txt * samples: added automl batch predict test * added missing package * Update tables/automl/batch_predict_test.py Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> * samples: fixed wrong format on GCS input Uri [(#4270)](GoogleCloudPlatform/python-docs-samples#4270) ## Description Current predict sample indicates that it can multiples GCS URI inputs but it should be singular. ## Checklist - [X] Please **merge** this PR for me once it is approved. * chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloudPlatform/python-docs-samples#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <coleleah@google.com> * Update automl_tables_predict.py with batch_predict_bq sample [(#4142)](GoogleCloudPlatform/python-docs-samples#4142) Added a new method `batch_predict_bq` demonstrating running batch_prediction using BigQuery. Added notes in comments about asynchronicity for `batch_predict` method. The region `automl_tables_batch_predict_bq` will be used on cloud.google.com (currently both sections for GCS and BigQuery use the same sample code which is incorrect). Fixes#4141 Note: It's a good idea to open an issue first for discussion. - [x] Please **merge** this PR for me once it is approved. * Update dependency pytest to v6 [(#4390)](GoogleCloudPlatform/python-docs-samples#4390) * chore: exclude notebooks * chore: update templates * chore: add codeowners and fix tests * chore: ignore warnings from sphinx * chore: fix tables client * test: fix unit tests Co-authored-by: Torry Yang <sirtorry@users.noreply.github.com> Co-authored-by: florencep <florenceperot@google.com> Co-authored-by: Mike Burton <mb-github@niskala.org> Co-authored-by: Lars Wander <lwander@users.noreply.github.com> Co-authored-by: Michael Hu <Michael.an.hu@gmail.com> Co-authored-by: Michael Hu <michaelanhu@gmail.com> Co-authored-by: Alefh Sousa <alefh.sousa@gmail.com> Co-authored-by: DPEBot <dpebot@google.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> Co-authored-by: Doug Mahugh <dmahugh@gmail.com> Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> Co-authored-by: Anthony <wens.ajw@gmail.com> Co-authored-by: Amy <amy@infosleuth.net> Co-authored-by: Mike <45373284+munkhuushmgl@users.noreply.github.com> Co-authored-by: Leah Cole <coleleah@google.com> Co-authored-by: Sergei Dorogin <github@dorogin.com>

This change aims to fix some string-related tests failing in #2248. Fixes internal issue 417774347 🦕

dhermes added testing do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: pubsub Issues related to the Pub/Sub API. api: logging Issues related to the Cloud Logging API. GAX labels Sep 16, 2016

dhermes assigned daspecster and tseaver Sep 16, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2016

dhermes mentioned this pull request Sep 16, 2016
GaxError is no longer raised in 0.13.0 when expected googleapis/gax-python#130
Closed

dhermes force-pushed the fix-0.13.0-gax branch from 7e81466 to 3b0a803Compare September 16, 2016 19:23

dhermes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 16, 2016

tseaver suggested changes Sep 16, 2016
View reviewed changes

dhermes added 2 commits September 19, 2016 08:57

Fixing broken exception handling after GAX 0.13.0 upgrade.
f916093

Making alias for grpc _Rendezvous.
b185ee8
Relates to googleapis#2156.

dhermes force-pushed the fix-0.13.0-gax branch from 3b0a803 to b185ee8Compare September 19, 2016 16:12

tseaver approved these changes Sep 19, 2016
View reviewed changes

dhermes merged commit 6fb2d73 into googleapis:masterSep 19, 2016

dhermes deleted the fix-0.13.0-gax branch September 19, 2016 16:43

dhermes mentioned this pull request Sep 19, 2016
Cut 0.19.0 release. #2270
Merged

dhermes mentioned this pull request Sep 19, 2016
Drop gcloud._helpers.exc_to_code once GAX moves off gRPC beta #2157
Closed

theacodes unassigned daspecster Sep 28, 2018

parthea pushed a commit that referenced this pull request Apr 1, 2026
refactor: fix some string ops in the sqlglot compiler (part 3) (#2336)
0f065c6
This change aims to fix some string-related tests failing in #2248. Fixes internal issue 417774347 🦕

Uh oh!

Conversation

dhermes commented Sep 16, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Sep 16, 2016

Uh oh!

dhermes commented Sep 16, 2016

Uh oh!

bjwatson commented Sep 17, 2016

Uh oh!

dhermes commented Sep 17, 2016

Uh oh!

tseaver commented Sep 18, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjwatson commented Sep 19, 2016

Uh oh!

dhermes commented Sep 19, 2016

Uh oh!

dhermes commented Sep 19, 2016

Uh oh!

daspecster commented Sep 19, 2016

Uh oh!

daspecster commented Sep 19, 2016

Uh oh!

dhermes commented Sep 19, 2016

Uh oh!

daspecster commented Sep 19, 2016

Uh oh!

daspecster commented Sep 19, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhermes commented Sep 19, 2016

Uh oh!

daspecster commented Sep 19, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhermes commented Sep 19, 2016

Uh oh!

daspecster commented Sep 19, 2016

Uh oh!

dhermes commented Sep 19, 2016

Uh oh!

dhermes commented Sep 19, 2016

Uh oh!

dhermes commented Sep 19, 2016

Uh oh!

dhermes commented Sep 19, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dhermes commented Sep 16, 2016•
edited
Loading

tseaver commented Sep 18, 2016•
edited
Loading

daspecster commented Sep 19, 2016•
edited
Loading

daspecster commented Sep 19, 2016•
edited
Loading