Skip to content

Review cleanup for PR #2344. - #2376

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:Fematich-fixup
Sep 21, 2016
Merged

Review cleanup for PR #2344.#2376
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:Fematich-fixup

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

@daspecster After this is in, feel free to run with the implementation (e.g. system tests, all features, etc.)

Remaining review issues not fixed by this PR:

@dhermesdhermes added hygiene api: speech Issues related to the Speech-to-Text API. labels Sep 21, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2016
Comment threaddocs/index.rst
bucket = client.get_bucket('<your-bucket-name>')
blob = bucket.blob('my-test-file.txt')
blob.upload_from_string('this is test content!') No newline at end of file
blob.upload_from_string('this is test content!')

This comment was marked as spam.

This comment was marked as spam.

Comment threaddocs/speech-usage.rst
... print('transcript: %s' % (alternative["transcript"],))
... print('confidence: %s' % (alternative["confidence"],))
... print('transcript: ' + alternative['transcript'])
... print('confidence: ' + alternative['confidence'])

This comment was marked as spam.

This comment was marked as spam.

@tseaver

Copy link
Copy Markdown
Contributor

LGTM

@daspecster

Copy link
Copy Markdown
Contributor

Did travis slow down on us again today?

@tseaver

Copy link
Copy Markdown
Contributor

@daspecster We can apparently get throttled due to builds throughout the organization.

@dhermes
dhermes merged commit 1f223f2 into googleapis:masterSep 21, 2016
@dhermes
dhermes deleted the Fematich-fixup branch September 21, 2016 19:07
parthea pushed a commit that referenced this pull request Apr 1, 2026
We will have more logging utilities in the future. It's better to
organize them into a separate directory now.
Related issue: 406578908
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: speechIssues related to the Speech-to-Text API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@tseaver@daspecster@googlebot