Skip to content

'Config.IN_EMULATOR' is a boolean. - #2381

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:system_tests-bigtable-false_positive_emulator_test
Sep 21, 2016
Merged

'Config.IN_EMULATOR' is a boolean.#2381
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:system_tests-bigtable-false_positive_emulator_test

Conversation

@tseaver

@tseavertseaver commented Sep 21, 2016

Copy link
Copy Markdown
Contributor

Five tests were being skipped due to false positves (testing if Config.IN_EMULATOR is not None: vs. if Config.IN_EMULATOR:).

@tseaver
'Config.IN_EMULATOR' is a boolean.
d1e0e12
Five tests were being skipped due to false positves (testing
'if Config.IN_EMULATOR is not None:' vs. 'if Config.IN_EMULATOR:'.
@tseavertseaver added testing api: bigtable Issues related to the Bigtable API. labels Sep 21, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2016
@dhermes

dhermes commented Sep 21, 2016

Copy link
Copy Markdown
Contributor

DERP! Sorry @tseaver. Should've been a boolean all along. My bad on not being careful with my find and replace

LGTM

@tseaver
tseaver merged commit c8a2517 into googleapis:masterSep 21, 2016
@tseaver
tseaver deleted the system_tests-bigtable-false_positive_emulator_test branch September 21, 2016 20:39
@dhermesdhermes mentioned this pull request Sep 29, 2016
Closed
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea@gcf-owl-bot
chore: update generated docs (#2381)
28e8aeb
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
@chelsea-lin
refactor: adds null literal checks when sqlglot compiling eq and nq o…
989b496
…ps (#2381)
This change adds null literal checks during the compilation of eq, ne
and map ops. This aims to resolve the
`test_series_replace_nans_with_pd_na` failure reported in #2248.
Fixes internal issue 417774347 🦕
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@dhermes@daspecster@googlebot