Skip to content

Upgrading number of PyLint jobs from 1 to 10. - #2401

Closed
dhermes wants to merge 1 commit into
googleapis:masterfrom
dhermes:update-pylint-config-round-3
Closed

Upgrading number of PyLint jobs from 1 to 10.#2401
dhermes wants to merge 1 commit into
googleapis:masterfrom
dhermes:update-pylint-config-round-3

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Marked "don't merge" for now because I want to actually time the difference on the entire codebase. Working on it now.

@dhermesdhermes added testing hygiene do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Sep 23, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2016
@tseaver

Copy link
Copy Markdown
Contributor

LGTM

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver May not be worth it.

At the current HEAD in master (or it was current until #2400 was merged)

$ git log -1 --pretty=%H
64353b5639a03ce9d2538eaf5fc112ea9019662e
$ rm -fr .tox/lint
$ time tox -e lint
...
real 3m17.283s
user 3m7.844s
sys 0m8.716s

at the HEAD in this PR

$ git log -1 --pretty=%H
dad810adf293f06dea50a459095a0e60924eb26f
$ rm -fr .tox/lint
$ tox -e lint --recreate --notest
$ time tox -e lint
...
real 3m26.578s
user 3m15.860s
sys 0m18.952s
$ time tox -e lint
...
real 3m21.792s
user 3m11.124s
sys 0m18.400s

So the extra jobs either

  • Add overhead without adding speed
  • Don't actually get set unless I do something else

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver

Copy link
Copy Markdown
Contributor

That PyCQA issue is supposed to be long-ago fixed.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver I'm pretty sure we don't get the speed-up because of the changes introduced in #1974 (I was on paternity leave at the time so didn't fully understand the change). In particular, the fact that we run Pylint on each file separately.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

Will revisit this some other time.

@dhermesdhermes closed this Nov 10, 2016
@dhermes
dhermes deleted the update-pylint-config-round-3 branch November 10, 2016 23:59
parthea added a commit that referenced this pull request Nov 24, 2025
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@tseaver@daspecster@googlebot