Skip to content

Move pubsub code into a subpackage - #2419

Merged
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:make-pubsub-subpackage
Sep 26, 2016
Merged

Move pubsub code into a subpackage#2419
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:make-pubsub-subpackage

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-pubsub-subpackage ../hotfix official/master
python make_commits.py \
--git-root "${PROJECT_DIR}/../hotfix" \
--package pubsub \
--package-name "Google Cloud Pub/Sub" \
--readme "${READMES_DIR}/pubsub/README.rst" \
--extra-requires $' \'grpcio >= 1.0.0\',\n \'google-gax >= 0.14.1, < 0.15dev\',\n \'gapic-google-pubsub-v1 >= 0.9.0, < 0.10dev\',\n \'grpc-google-pubsub-v1 >= 0.9.0, < 0.10dev\',\n'

NOTE: Since only pubsub and logging had to remove extra deps from GRPC_PACKAGES in setup.py, the 3rd commit is just written the old-fashioned way.

@dhermesdhermes added api: pubsub Issues related to the Pub/Sub API. api: logging Issues related to the Cloud Logging API. labels Sep 25, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2016
@dhermes
dhermesforce-pushed the make-pubsub-subpackage branch from df84621 to 6ed1a94CompareSeptember 26, 2016 16:32
@tseaver

Copy link
Copy Markdown
Contributor

LGTM

@dhermes

Copy link
Copy Markdown
ContributorAuthor

Not going to merge this, going to merge #2420 and GitHub will magically close this PR.

Done via:
$ mkdir -p pubsub/google/cloud
$ cp google/__init__.py pubsub/google/__init__.py
$ git add pubsub/google/__init__.py
$ cp google/cloud/__init__.py pubsub/google/cloud/__init__.py
$ git add pubsub/google/cloud/__init__.py
$ git mv google/cloud/pubsub pubsub/google/cloud/pubsub
$ git mv unit_tests/pubsub pubsub/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-pubsub as a dependency to the umbrella
package
- Adding the pubsub subdirectory into the list of packages
for verifying the docs
- Incorporating the pubsub subdirectory into the umbrella
coverage report
- Adding the pubsub only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the pubsub
tox config
@dhermes
dhermesforce-pushed the make-pubsub-subpackage branch from 6ed1a94 to 27380f9CompareSeptember 26, 2016 19:48
@dhermes
dhermes merged commit 27380f9 into googleapis:masterSep 26, 2016
@dhermes
dhermes deleted the make-pubsub-subpackage branch September 26, 2016 19:50
parthea pushed a commit that referenced this pull request Apr 1, 2026
This PR refines the visual feedback provided during operation progress.
Specifically, it prevents the display of a standalone "✅ Completed."
message and green checkmark when no query execution information (like
slot time or bytes processed) is available. This often occurs during
metadata-only operations or cached results where the "Completed" status
is redundant.
Fixes #<479944983> 🦕
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: loggingIssues related to the Cloud Logging API.api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@tseaver@theacodes@googlebot