Skip to content

Move monitoring code into a subpackage - #2430

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:make-monitoring-subpackage
Sep 26, 2016
Merged

Move monitoring code into a subpackage#2430
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:make-monitoring-subpackage

Conversation

@dhermes

@dhermesdhermes commented Sep 26, 2016

Copy link
Copy Markdown
Contributor

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-monitoring-subpackage ../hotfix official/master
python make_commits.py \
--git-root "${PROJECT_DIR}/../hotfix" \
--package monitoring \
--package-name "Stackdriver Monitoring" \
--readme "${READMES_DIR}/monitoring/README.rst"

@dhermesdhermes added packaging api: monitoring Issues related to the Cloud Monitoring API. labels Sep 26, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2016
@dhermesdhermes mentioned this pull request Sep 26, 2016
Closed
32 tasks
theacodes
theacodes reviewed Sep 26, 2016
View reviewed changes
Comment threadmonitoring/README.rst

::

$ pip install --upgrade google-cloud-monitoring

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
dhermesforce-pushed the make-monitoring-subpackage branch 2 times, most recently from 2c28250 to e2a394eCompareSeptember 26, 2016 21:49
@dhermes
Moving all monitoring files into subdirectory.
51b1b77
Done via:
$ mkdir -p monitoring/google/cloud
$ cp google/__init__.py monitoring/google/__init__.py
$ git add monitoring/google/__init__.py
$ cp google/cloud/__init__.py monitoring/google/cloud/__init__.py
$ git add monitoring/google/cloud/__init__.py
$ git mv google/cloud/monitoring monitoring/google/cloud/monitoring
$ git mv unit_tests/monitoring monitoring/unit_tests
@dhermes
Making monitoring subpackage into a proper package.
454dde3
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-monitoring as a dependency to the umbrella
package
- Adding the monitoring subdirectory into the list of packages
for verifying the docs
- Incorporating the monitoring subdirectory into the umbrella
coverage report
- Adding the monitoring only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the monitoring
tox config
@dhermes
dhermesforce-pushed the make-monitoring-subpackage branch from e2a394e to 454dde3CompareSeptember 26, 2016 23:20
@dhermes

dhermes commented Sep 26, 2016

Copy link
Copy Markdown
ContributorAuthor

Rebased on top of #2435.

Green build

@dhermes
dhermes merged commit 011e56d into googleapis:masterSep 26, 2016
@dhermes
dhermes deleted the make-monitoring-subpackage branch September 26, 2016 23:20
@dhermesdhermes mentioned this pull request Sep 26, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
@release-please@parthea
chore(main): release 1.26.1 (#2430)
2270ab9
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
@chelsea-lin
refactor: EnableSELECT *optimization in the sqlglot compiler (#2430)
620ed1b
Fixes internal issue 481740136 🦕
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@theacodestheacodestheacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tseavertseaver

@theacodestheacodes

Labels

api: monitoringIssues related to the Cloud Monitoring API.cla: yesThis human has signed the Contributor License Agreement.packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@theacodes@tseaver@googlebot