Skip to content

Running restricted set of unit tests on Travis PR. - #2484

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:collapse-travis-config-3
Oct 3, 2016
Merged

Running restricted set of unit tests on Travis PR.#2484
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:collapse-travis-config-3

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

NOTE: Has #2475 as diffbase.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2016
@daspecster

Copy link
Copy Markdown
Contributor

@dhermes this has a conflict too. Otherwise LGTM.

@dhermes
dhermesforce-pushed the collapse-travis-config-3 branch from e2dd6ca to 324a2c3CompareOctober 3, 2016 20:43
@dhermes

Copy link
Copy Markdown
ContributorAuthor

@daspecster I just rebased and it seemed to fix itself?

@dhermes
dhermes merged commit 72291ea into googleapis:masterOct 3, 2016
@dhermes
dhermes deleted the collapse-travis-config-3 branch October 3, 2016 20:51
@dhermes

Copy link
Copy Markdown
ContributorAuthor

Build time down from 20 minutes to about 7.5 minutes. But it used to be consistently under 4, so I still have work to do.

@tseaver

Copy link
Copy Markdown
Contributor

I don't see any special handling for changes in core/ -- because it is a dependency for everything else, should we be falling back to running all tests when any change happens there?

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver I've got a change coming down the pipe which computes a package dependency graph and then follows the tree to populate a more-full list of changes. Thanks for being heads up!

parthea pushed a commit that referenced this pull request Apr 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@daspecster@tseaver@googlebot