Uh oh!
There was an error while loading. Please reload this page.
Use 'diff_base' for pycodestyle check, if set. - #2486
Merged
Conversation
Speeds it up, plus reduces spew when testing locally.
| os.chdir(git_root) | ||
| python_files = subprocess.check_output(['git', 'ls-files', '*py']) | ||
| python_files = python_files.strip().split() | ||
| candidates, _ = get_files_for_linting() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
Oct 3, 2016
Contributor
@tseaver I recently introduced |
dhermes
reviewed
Oct 4, 2016
| import subprocess | ||
| import sys | ||
| from script_utils import get_files_for_linting |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
reviewed
Oct 4, 2016
| be used. | ||
| :rtype: pair | ||
| :returns: Tuple of the diff base using the the list of filenames to be |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Also, fix a "the the" typo.
dhermes added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 5, 2016
Issue introduced in googleapis#2486.
dhermes added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 6, 2016
Was an unintended side-effect of googleapis#2486.
dhermes added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 6, 2016
Was an unintended side-effect of googleapis#2486.
dhermes added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 6, 2016
Issue introduced in googleapis#2486.
richkadel pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Was an unintended side-effect of googleapis#2486.
parthea pushed a commit
that referenced
this pull request
Apr 1, 2026
This change is cleaning up remaining Python 3.9 support codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds it up, plus reduces spew when testing locally.