Skip to content

Making max_results part of the base Iterator class. - #2490

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-1467
Oct 4, 2016
Merged

Making max_results part of the base Iterator class.#2490
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-1467

Conversation

@dhermes

@dhermesdhermes commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

In the process, also making sure to lower maxResults on subsequent requests.

Fixes#1467.

@dhermesdhermes added api: storage Issues related to the Cloud Storage API. api: core labels Oct 4, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2016
dhermes
dhermes commented Oct 4, 2016
View reviewed changes
Comment threadcore/google/cloud/iterator.py Outdated
except StopIteration:
item = self._update_items()
self.num_results += 1
return item

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Oct 4, 2016

Copy link
Copy Markdown
ContributorAuthor

I'm very open to suggestions on other unit / system tests I could add to this PR. Just wanted to get it out there for discussion's sake.

@dhermes
Making max_results part of the base Iterator class.
78b09c5
In the process, also making sure to lower maxResults
on subsequent requests.
Fixesgoogleapis#1467.
@tseaver

tseaver commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

I would've thought changing to use google.cloud.iterator.MethodIterator everywhere would have been more straightforward (and giving us a clearer path toward a general solution for #895). The derived iterator classes feel like roach motels to me.

@dhermes

dhermes commented Oct 4, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver This is just a band-aid for #1467. I will probably start from scratch / build on top of MethodIterator when finishing #895.

@tseavertseaver mentioned this pull request Oct 4, 2016
Closed
@dhermes
dhermes merged commit 8c50e41 into googleapis:masterOct 4, 2016
@dhermes
dhermes deleted the fix-1467 branch October 4, 2016 21:55
@dhermesdhermes mentioned this pull request Nov 14, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull requestgoogleapis#2490from dhermes/fix-1467
4a82b09
Making max_results part of the base Iterator class.
parthea pushed a commit that referenced this pull request Apr 1, 2026
@chelsea-lin
test: align remote function ingress with new GCP policies (#2490)
c62cfd9
Fixes internal issue 489454080🦕
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@daspecsterdaspecsterdaspecster left review comments
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tseavertseaver

Labels

api: coreapi: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@tseaver@daspecster@googlebot