Skip to content

Make 'encryption_key' an attribute of the Blob. - #2507

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:1960-storage-blob_encryption_key_attr
Oct 6, 2016
Merged

Make 'encryption_key' an attribute of the Blob.#2507
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:1960-storage-blob_encryption_key_attr

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Avoids the need to plumb it through all the upload_* and download_* methods.

Convert _set_encryption_headers(key, headers) into a pure function, _get_encryption_headers(key), returning a new dict.

Preparing for use of encryption in to-be-added Blob.rewrite(source_blob) method. See: #1960.

@tseavertseaver added the api: storage Issues related to the Cloud Storage API. label Oct 6, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2016
@tseaver

Copy link
Copy Markdown
ContributorAuthor

/cc @jonparrott, as this change might affect the snippets which demonstrate use of customer-supplied encryption keys.

Avoids the need to plumb it through all the 'upload' and 'download'
methods.
Convert '_set_encryption_headers(key, headers)' into a pure function,
'_get_encryption_headers(key)', returning a new dict.
Preparing for use of encryption in to-be-added 'Blob.rewrite(source_blob)'
method. See: #1960.

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhermes

Copy link
Copy Markdown
Contributor

Still LGTM after last commit

@tseaver

Copy link
Copy Markdown
ContributorAuthor

@dhermes While writing system tests for Blob.rewrite, I realized I needed to surface the encryption_key parameter at the Bucket.blob level, too. Unless you object, I will merge when that last, tiny change passes Travis.

@tseaver
tseaver merged commit cc4c929 into googleapis:masterOct 6, 2016
@tseaver
tseaver deleted the 1960-storage-blob_encryption_key_attr branch October 6, 2016 21:12
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
…ryption_key_attr
Make 'encryption_key' an attribute of the Blob.
chalmerlowe pushed a commit that referenced this pull request Mar 31, 2026
chalmerlowe pushed a commit that referenced this pull request Mar 31, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v0.8.3
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c
<details><summary>bigframes: v2.38.0</summary>
##
[v2.38.0](google/bigframes@v2.37.0...v2.38.0)
(2026-03-16)
### Features
* Add `bigframes.bigquery.rand()` function (#2501)
([5c43efb7](google/bigframes@5c43efb7))
* add `df.bigquery` pandas accessor (#2513)
([91b6c245](google/bigframes@91b6c245))
* Add str, dt accessors to pd.col Expression objects (#2488)
([ce5de570](google/bigframes@ce5de570))
* add bigquery.ml.get_insights function (#2493)
([d29a6095](google/bigframes@d29a6095))
* use EUC for AI IF, CLASSIFY, and SCORE when connection is not provided
(#2507)
([fe94910a](google/bigframes@fe94910a))
### Bug Fixes
* handle unsupported types and empty results in describe (#2506)
([2326ad6a](google/bigframes@2326ad6a))
* no longer automatically use anywidget in the `%%bqsql` magics (#2504)
([43353e2b](google/bigframes@43353e2b))
### Documentation
* Fix typo in ExperimentOptions class docstring (#2498)
([077cb2eb](google/bigframes@077cb2eb))
* add notebooks to user guide page (#2505)
([5cf37888](google/bigframes@5cf37888))
</details>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@dhermes@daspecster@googlebot