Skip to content

Moving to iterators in DNS. - #2532

Closed
dhermes wants to merge 1 commit into
googleapis:masterfrom
dhermes:dns-iterators
Closed

Moving to iterators in DNS.#2532
dhermes wants to merge 1 commit into
googleapis:masterfrom
dhermes:dns-iterators

Conversation

@dhermes

@dhermesdhermes commented Oct 12, 2016

Copy link
Copy Markdown
Contributor

NOTE: Has #2531 as diffbase.

In doing this, I realized it's a bit tedious to have to write two classes (page and iterator) for each method. It may be more user-friendly to collapse back into one class. I think I could do it mostly by just making anything that is accessed via self.page.foo as self.page_foo.

@dhermesdhermes added the api: dns Issues related to the Cloud DNS API. label Oct 12, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2016
@dhermes

Copy link
Copy Markdown
ContributorAuthor

@daspecster@tseaver@jonparrott PTAL.

There will be about 5 more PRs like this for each package which does page token list_foo().

@theacodestheacodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward to me.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

TRAVIS!

@theacodes

Copy link
Copy Markdown
Contributor

TRAVIS!

No travis for you, I used up all of his cycles in google-auth. :P

@tseaver

tseaver commented Oct 17, 2016

Copy link
Copy Markdown
Contributor

I don't really care for the inheritance-based iterator approach: would it be better to tackle that first in #2531#2548? Or merge this and then maybe refactor, killing of the subclasses?

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver Can you weigh in on #2558 ASAP?

@dhermesdhermes mentioned this pull request Oct 18, 2016
@dhermesdhermes closed this Oct 18, 2016
@dhermes
dhermes deleted the dns-iterators branch October 18, 2016 20:21
ohmayr pushed a commit that referenced this pull request Mar 13, 2026
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
chalmerlowe pushed a commit that referenced this pull request Apr 1, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c
<details><summary>bigframes: 2.39.0</summary>
##
[2.39.0](google/bigframes@v2.38.0...v2.39.0)
(2026-03-31)
### Features
* add `df.bigquery.ai.forecast` method to pandas dataframe accessor
(#2518)
([1126cec9](google/bigframes@1126cec9))
* support full round-trip persistence for multimodal reference cols
(#2511)
([494a0a11](google/bigframes@494a0a11))
* expose DataFrame.bigquery in both pandas and bigframes DataFrames
(#2533)
([69fe3176](google/bigframes@69fe3176))
### Bug Fixes
* to_gbq may swap data columns when replace table (#2532)
([17ecc65e](google/bigframes@17ecc65e))
* handle aggregate operations on empty selections (#2510)
([34fb5daa](google/bigframes@34fb5daa))
* Localize BigQuery log suppression for gbq.py (#2541)
([af49ca29](google/bigframes@af49ca29))
* Respect remote function config changes even if logic unchanged (#2512)
([b9524284](google/bigframes@b9524284))
* support melting empty DataFrames without crashing (#2509)
([e8c4603](google/bigframes@e8c46032))
### Performance Improvements
* Make executor data uploads async internally (#2529)
([96597f0b](google/bigframes@96597f0b))
### Documentation
* gemini retouch of the index page for seo (#2514)
([2e5311e2](google/bigframes@2e5311e2))
* Rename Blob column references to ObjectRef column (#2535)
([44e0ffd9](google/bigframes@44e0ffd9))
</details>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dnsIssues related to the Cloud DNS API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes@theacodes@tseaver@daspecster@googlebot