Replace types string with str.

[tswast]

Based on this comment: #2485 (comment)

For rtypes, used the command:

ag -l 'rtype: string' | xargs sed -i .bak 's/rtype: string/rtype: str/g'

For types, used the command:

ag -l 'type ([^:]+): string' | \
xargs gsed -r -i.bak -e 's/type ([^:]+): string/type \1: str/g'

Note: -r for gsed (GNU sed) is needed for group matching.

[theacodes]

😆

[dhermes]

I actually reviewed every line. Why? Because I'm crazy.

LGTM

(I think it'll be hilarious if Travis / Sphinx barfs on this.)

[tswast]

Thanks. For reviewing. I just added some commits for boolean -> bool, too, based on #2485 (comment)

[dhermes]

Thanks. For reviewing. I just added some commits for boolean -> bool, too

GAH! Next time, please "heads up new code" first, then push to the PR. (Since review already finished.) Preference: send two PRs.

[dhermes]

@tswast bool stuff looks good too. Ping me (or @jonparrott) when Travis is green?

[tswast]

Works for me. (Two PRs next time and pinging for Travis)