Uh oh!
There was an error while loading. Please reload this page.
Remapping (almost) all RPC status codes to our exceptions in datastore. - #2590
Conversation
| _datastore_pb2.AllocateIdsResponse) | ||
| def _grpc_catch_rendezvous(to_call, *args, **kwargs): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
Oct 24, 2016
daspecster
commented
Oct 24, 2016
I like this better IMHO. |
dhermes
commented
Oct 24, 2016
FYI I am toying with Circle CI. Looks like Travis is being helpful for the time being though |
tseaver
commented
Oct 24, 2016
Sorry to be late to the party. Wouldn't the |
dhermes
commented
Oct 24, 2016
@tseaver I intentionally didn't do that, mindful of two things:
|
tseaver
commented
Oct 25, 2016
@dhermes FWIW, anywhere we are currently sniffing at core/google/cloud/_testing.py
core/google/cloud/streaming/exceptions.py
core/google/cloud/streaming/http_wrapper.py
core/unit_tests/streaming/test_http_wrapper.py
datastore/google/cloud/datastore/_generated/datastore_grpc_pb2.py
datastore/google/cloud/datastore/connection.py
datastore/unit_tests/test_connection.py
docs/error-reporting-usage.rst
error_reporting/google/cloud/error_reporting/client.py
error_reporting/unit_tests/test_client.py
logging/google/cloud/logging/_gax.py
pubsub/google/cloud/pubsub/_gax.py |
dhermes
commented
Oct 25, 2016
OK. |
Remapping (almost) all RPC status codes to our exceptions in datastore.
Remapping (almost) all RPC status codes to our exceptions in datastore.
Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>
Fixes#2497.
(Relevant to #2583 as well.)
FYI @jonparrott