Skip to content

Make Encoding accessible from speech.Encoding. - #2597

Merged
daspecster merged 3 commits into
googleapis:masterfrom
daspecster:speech-streaming-part-1
Oct 24, 2016
Merged

Make Encoding accessible from speech.Encoding.#2597
daspecster merged 3 commits into
googleapis:masterfrom
daspecster:speech-streaming-part-1

Conversation

@daspecster

Copy link
Copy Markdown
Contributor

@dhermes per our discussion the other day, this moves Encoding to speech.

@daspecsterdaspecster added the api: speech Issues related to the Speech-to-Text API. label Oct 24, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2016
@daspecster
daspecsterforce-pushed the speech-streaming-part-1 branch from 7ac073b to 76afbe3CompareOctober 24, 2016 17:44
@dhermes

Copy link
Copy Markdown
Contributor

LGTM. Nice catch on the misaligned text in the docs. Also, FWIW the import didn't need to change in the unit tests, just in user facing stuff (i.e. we don't feel like importing members directly from modules is a burden, but it is a burden on users to keep track of all the many modules we have)

@daspecster

Copy link
Copy Markdown
ContributorAuthor

Ok, I have some questions about unit tests in general, I should probably open an issue for them?

@daspecster
daspecster merged commit fd0cf13 into googleapis:masterOct 24, 2016
@daspecster
daspecster deleted the speech-streaming-part-1 branch October 24, 2016 17:55
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
…art-1
Make Encoding accessible from speech.Encoding.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: speechIssues related to the Speech-to-Text API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@daspecster@dhermes@googlebot