Add Speech GAPIC for sync_recognize. by daspecster · Pull Request #2615 · googleapis/google-cloud-python

daspecster · 2016-10-25T23:28:51Z

This adds GAPIC support to speech sync_recognize().

dhermes

Some comments, as discussed in chat, the impl. should resemble the Pub/Sub and Logging implementations, i.e. separation of concerns by having HTTP-only and GAX-only API objects.

Sign in to view

 return cls(transcript['transcript'], transcript['confidence'])

+ @classmethod
+ def from_pb(cls, transcript):


Sign in to view

+ def from_pb(cls, transcript):
+ """Factory: construct ``Transcript`` from protobuf response.
+
+ :type transcript: :class:`SpeechRecognitionAlternative`


Sign in to view

+ :param transcript: Instance of ``SpeechRecognitionAlternative``
+ from protobuf.
+
+ :rtype: :class:`~Transcript`


Sign in to view

- max_alternatives=2,
- profanity_filter=True,
- speech_context=self.HINTS)
+ with _Monkey(MUT, _USE_GAX=False):


Sign in to view

 sample = Sample(source_uri=self.AUDIO_SOURCE_URI, encoding=encoding,
 sample_rate=self.SAMPLE_RATE)
- response = client.sync_recognize(sample)
+ with _Monkey(MUT, _USE_GAX=False):


Sign in to view

- encoding=speech.Encoding.FLAC,
- sample_rate=self.SAMPLE_RATE)
- client.sync_recognize(sample)
+ with self.assertRaises(IndexError):


Sign in to view

- sample_rate=self.SAMPLE_RATE)
- client.sync_recognize(sample)
+ with self.assertRaises(IndexError):
+ with _Monkey(MUT, _USE_GAX=False):


Sign in to view



+class _RecognitionConfig(object):
+ def __init__(self, *args, **kwargs):


dhermes

Big 👍 on the refactor

Sign in to view

@@ -0,0 +1,76 @@
+


Sign in to view

+_USE_GAX = _HAVE_GAX and not _DISABLE_GAX
+
+
+class Client(JSONClient):


Sign in to view

+try:
+ from google.cloud.speech._gax import GAPICSpeechAPI
+except ImportError: # pragma: NO COVER
+ _HAVE_GAX = False


Sign in to view

+ """Helper for speech-related API calls."""
+ if self._speech_api is None:
+ if self._use_gax:
+ self._speech_api = GAPICSpeechAPI()


Sign in to view

- profanity_filter, speech_context)

- api_response = self.connection.api_request(
+class JSONSpeechAPI(object):


Sign in to view

 self.assertFalse(operation.complete)
 self.assertIsNone(operation.metadata)

+ def test_speech_api_with_gapic(self):


Sign in to view

+ api = client.speech_api
+ self.assertIsInstance(api, _MockGAPICSpeechAPI)
+
+ def test_speech_api_without_gapic(self):


Sign in to view

+ api = client.speech_api
+ self.assertIsInstance(api, _MockJSONSpeechAPI)
+
+ def test_speech_api_preset(self):


Sign in to view

+
+
+class GAPICSpeechAPI(object):
+ """Object to manage calls through GAPIC wrappers to the Speech API."""


Sign in to view

+ uri=sample.source_uri)
+ api = self._gapic_api
+ api_response = api.sync_recognize(config=config, audio=audio)
+ results = api_response.results.pop()


Sign in to view

 REQUIREMENTS = [
 'google-cloud-core >= 0.20.0',
+ 'gapic-google-cloud-speech-v1beta1==0.11.1',
+ 'grpc-google-cloud-speech-v1beta1==0.11.1',


Sign in to view

 credentials = _Credentials()
- client = self._makeOne(credentials=credentials)
+ client = self._makeOne(credentials=credentials, use_gax=False)
 client.connection = _Connection(RETURNED)


daspecster · 2016-10-26T03:53:35Z

It looks like SpeechApi() does some credential digging.
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/170660357#L201-L212

So I _Monkey'd SpeechApi back.

@dhermes I think I got everything you covered there. LMKWYT.

daspecster · 2016-10-26T04:24:30Z

Yeah I was trying something with testing. I just pushed that back up.

daspecster · 2016-10-26T04:27:26Z

Ok yeah, that causes an error.
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/170666346#L461-L474
I think because of this https://pypi.python.org/pypi/grpc-google-cloud-speech-v1beta1/1.0.0

daspecster · 2016-10-26T04:42:05Z

Ok that should be resolved now.

'gapic-google-cloud-speech-v1beta1>=0.11.1,<0.12.0',
'grpc-google-cloud-speech-v1beta1>=0.11.1,<0.12.0',

dhermes · 2016-10-26T05:05:12Z

LGTM.

Add Speech GAPIC for sync_recognize.

daspecster added the api: speech Issues related to the Speech-to-Text API. label Oct 25, 2016

daspecster assigned tseaver and dhermes Oct 25, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2016

daspecster mentioned this pull request Oct 25, 2016
Tracking Speech API development. #2522
Closed
14 tasks

dhermes reviewed Oct 25, 2016
View reviewed changes

dhermes reviewed Oct 26, 2016
View reviewed changes

daspecster force-pushed the add-speech-sync-gapic branch from 7e2e8f4 to e24e96aCompare October 26, 2016 03:48

daspecster force-pushed the add-speech-sync-gapic branch 2 times, most recently from d3d3ced to 9c3a578Compare October 26, 2016 04:38

Add Speech GAPIC for sync_recognize.
9031a0f

daspecster force-pushed the add-speech-sync-gapic branch from 29cb827 to 9031a0fCompare October 26, 2016 05:07

daspecster merged commit 2e6ac38 into googleapis:masterOct 26, 2016

daspecster deleted the add-speech-sync-gapic branch October 26, 2016 05:25

dhermes mentioned this pull request Nov 14, 2016
Upgrading core to version to 0.21.0. #2733
Merged

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Merge pull requestgoogleapis#2615from daspecster/add-speech-sync-gapic
dce4dfe
Add Speech GAPIC for sync_recognize.

theacodes unassigned dhermes Sep 28, 2018

atulep pushed a commit that referenced this pull request Apr 3, 2023
Merge pull request#2615from daspecster/add-speech-sync-gapic
6fd2058
Add Speech GAPIC for sync_recognize.

atulep pushed a commit that referenced this pull request Apr 18, 2023
Merge pull request#2615from daspecster/add-speech-sync-gapic
898f5ad
Add Speech GAPIC for sync_recognize.

parthea pushed a commit that referenced this pull request Oct 22, 2023
Merge pull request#2615from daspecster/add-speech-sync-gapic
91a1927
Add Speech GAPIC for sync_recognize.



		class _RecognitionConfig(object):
		def __init__(self, args, *kwargs):

		_USE_GAX = _HAVE_GAX and not _DISABLE_GAX


		class Client(JSONClient):



		class GAPICSpeechAPI(object):
		"""Object to manage calls through GAPIC wrappers to the Speech API."""

Uh oh!

Conversation

daspecster commented Oct 25, 2016

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

daspecster commented Oct 26, 2016•
edited
Loading