Skip to content

Updating list_sinks() to Iterator pattern. - #2652

Merged
dhermes merged 4 commits into
googleapis:masterfrom
dhermes:logging-iterators-sinks
Oct 31, 2016
Merged

Updating list_sinks() to Iterator pattern.#2652
dhermes merged 4 commits into
googleapis:masterfrom
dhermes:logging-iterators-sinks

Conversation

@dhermes

@dhermesdhermes commented Oct 31, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

NOTE: Has #2651 as diffbase. Unit test changes will be forthcoming.

@dhermesdhermes added the api: logging Issues related to the Cloud Logging API. label Oct 31, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2016
@dhermes

dhermes commented Oct 31, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver@daspecster PTAL this is ready to go

@dhermes
dhermesforce-pushed the logging-iterators-sinks branch from d4cd270 to 035ec7fCompareOctober 31, 2016 22:39
@dhermesdhermes mentioned this pull request Oct 31, 2016
Merged
daspecster
daspecster reviewed Oct 31, 2016
View reviewed changes
Comment threadlogging/google/cloud/logging/_helpers.py

:type resource: dict
:param resource: one entry resource from API response
:param resource: One entry resource from API response.

This comment was marked as spam.

Sign in to view

daspecster
daspecster reviewed Oct 31, 2016
View reviewed changes
Comment threadlogging/unit_tests/test_connection.py
token = iterator.next_page_token

self.assertEqual(sinks, RETURNED['sinks'])
# First check the token.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster

daspecster commented Oct 31, 2016

Copy link
Copy Markdown
Contributor

This LGTM as well.

@dhermes
dhermesforce-pushed the logging-iterators-sinks branch from 035ec7f to c351c05CompareOctober 31, 2016 23:16
@dhermes
dhermes merged commit 94aa18c into googleapis:masterOct 31, 2016
@dhermes
dhermes deleted the logging-iterators-sinks branch October 31, 2016 23:22
tseaver
tseaver reviewed Nov 1, 2016
View reviewed changes
Comment threadlogging/unit_tests/test__gax.py
token = iterator.next_page_token

self.assertEqual(sinks, SINKS)
# First check the token.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver
tseaver reviewed Nov 1, 2016
View reviewed changes
Comment threadlogging/unit_tests/test_client.py
iterator = client.list_sinks()
page = six.next(iterator.pages)
sinks = list(page)
token = iterator.next_page_token

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermesdhermes mentioned this pull request Nov 14, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull requestgoogleapis#2652from dhermes/logging-iterators-sinks
9547388
Updating list_sinks() to Iterator pattern.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Merge pull request#2652from dhermes/logging-iterators-sinks
691db6c
Updating list_sinks() to Iterator pattern.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@daspecsterdaspecsterdaspecster left review comments
@tseavertseavertseaver left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tseavertseaver

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@daspecster@tseaver@googlebot