Skip to content

Updating list_metrics() to Iterator pattern. - #2653

Merged
dhermes merged 4 commits into
googleapis:masterfrom
dhermes:logging-iterators-metrics
Nov 1, 2016
Merged

Updating list_metrics() to Iterator pattern.#2653
dhermes merged 4 commits into
googleapis:masterfrom
dhermes:logging-iterators-metrics

Conversation

@dhermes

@dhermesdhermes commented Oct 31, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

NOTE: Has #2651 as diffbase. Unit test changes will be forthcoming.

@dhermesdhermes added the api: logging Issues related to the Cloud Logging API. label Oct 31, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2016
@dhermes
dhermesforce-pushed the logging-iterators-metrics branch 2 times, most recently from fc6e57f to 5b33597CompareOctober 31, 2016 23:31
@dhermes

dhermes commented Oct 31, 2016

Copy link
Copy Markdown
ContributorAuthor

@daspecster@tseaver PTAL

@tseaver

tseaver commented Nov 1, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

pyilnt failure:

logging/google/cloud/logging/_gax.py:500:1: E303 too many blank lines (3)

@dhermes
dhermesforce-pushed the logging-iterators-metrics branch from 5b33597 to ce40029CompareNovember 1, 2016 04:46
@dhermes

dhermes commented Nov 1, 2016

Copy link
Copy Markdown
ContributorAuthor

Ahhhh! Darn rebases. PTAL.

Was that your only issue?

@tseaver

tseaver commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

I didn't really review it in detail since Travis was red.

@dhermes

dhermes commented Nov 1, 2016

Copy link
Copy Markdown
ContributorAuthor

OK well it's good to go now. LMK what you think

tseaver
tseaver reviewed Nov 1, 2016
View reviewed changes
Comment threadlogging/unit_tests/test_client.py
returned = {
'metrics': METRICS,
}
client.connection = _Connection(returned)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadlogging/unit_tests/test_client.py Outdated
token = iterator.next_page_token

# First check the token.
self.assertIsNone(token)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
dhermesforce-pushed the logging-iterators-metrics branch from ce40029 to 9cf835cCompareNovember 1, 2016 16:24
@dhermes

dhermes commented Nov 1, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver PTAL

@dhermes
dhermes merged commit b4d87f7 into googleapis:masterNov 1, 2016
@dhermes
dhermes deleted the logging-iterators-metrics branch November 1, 2016 16:52
@dhermesdhermes mentioned this pull request Nov 14, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull requestgoogleapis#2653from dhermes/logging-iterators-met…
ac63bce
…rics
Updating list_metrics() to Iterator pattern.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Merge pull request#2653from dhermes/logging-iterators-metrics
3e86b12
Updating list_metrics() to Iterator pattern.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tseavertseaver

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@tseaver@daspecster@googlebot