Add speech async gapic by daspecster · Pull Request #2663 · googleapis/google-cloud-python

daspecster · 2016-11-02T03:06:08Z

~~This will need #2661 in order for travis-ci to pass since I don't need metadata.py and operation.py after @dhermes refactored the core operation.py@ Thanks!~~

@dhermes, I think we talked about this back and forth a little bit, but as you can see from the system tests, the surface is much different between sync_recognize()'s results and async_recognize()'s results.

There will be some updates for the gRPC version of sync_recognize() that will follow this as well.

Sign in to view

 REQUIREMENTS = [
 'google-cloud-core >= 0.20.0',
+ 'grpcio >= 1.0.0, < 2.0dev',
+ 'google-gax >= 0.14.1, < 0.15dev',


Sign in to view

+from google.cloud._helpers import make_secure_stub
+from google.cloud.connection import DEFAULT_USER_AGENT
+from google.cloud.speech.operation import Operation
+from google.cloud.operation import register_type


Sign in to view

+OPERATIONS_API_HOST = 'speech.googleapis.com'
+
+register_type(AsyncRecognizeMetadata)
+register_type(AsyncRecognizeResponse)


Sign in to view

 words to the vocabulary of the recognizer.

- :raises NotImplementedError: Always.
+ :rtype: :class:`~google.cloud.operation.Opeartion`


Sign in to view

+ api = self._gapic_api
+ response = api.async_recognize(config=config, audio=audio)
+
+ self._client._operations_stub = make_secure_stub(


Sign in to view

 REQUIREMENTS = [
 'google-cloud-core >= 0.20.0',
 'gapic-google-cloud-speech-v1beta1 >= 0.11.1, < 0.12.0',
- 'grpc-google-cloud-speech-v1beta1 >= 0.11.1, < 0.12.0',


Sign in to view

 credentials = _Credentials()
 client = self._makeOne(credentials=credentials, use_gax=True)
 client.connection = _Connection()
+ _MockGAPICSpeechAPI._results = []


Sign in to view

 credentials = _Credentials()
 client = self._makeOne(credentials=credentials)
 client.connection = _Connection()
+ client.connection.credentials = credentials


Sign in to view

+ operation = client.async_recognize(sample)
+
+ self.assertFalse(operation.complete)
+ self.assertIsNone(operation.response)


Sign in to view



+class _MockGAPICMetadata(object):
+ type_url = None


daspecster · 2016-11-02T21:41:20Z

@dhermes I think there are just thow two open questions. Did you have anything else?

Sign in to view

+ @staticmethod
+ def _make_result(transcript, confidence):
+ from google.cloud.grpc.speech.v1beta1 import cloud_speech_pb2
+ return cloud_speech_pb2.SpeechRecognitionResult(


Sign in to view

+ alternatives=[
+ cloud_speech_pb2.SpeechRecognitionAlternative(
+ transcript=transcript,
+ confidence=confidence,


Sign in to view

+
+ def _make_sync_response(self, *results):
+ from google.cloud.grpc.speech.v1beta1 import cloud_speech_pb2
+ response = cloud_speech_pb2.SyncRecognizeResponse(


Sign in to view

- from google.cloud.speech import _gax as MUT
+
 from google.cloud import speech
+ from google.cloud.speech import _gax as MUT


Sign in to view

 client.connection = _Connection()
+ client.connection.credentials = credentials
+
+ _MockGAPICSpeechAPI._response = self._make_sync_response()


Sign in to view

 credentials = _Credentials()
 client = self._makeOne(credentials=credentials)
 client.connection = _Connection()
+ client.connection.credentials = credentials


Sign in to view

- mock_response = self._response
- mock_response.results = self._results
- return mock_response
+ # self._response.results = self._results


Sign in to view

+ _results = None
+
+ def async_recognize(self, config, audio):
+ from google.longrunning.operations_pb2 import Operation


Sign in to view

+ "confidence": 0.9224355
+ }, {
+ "transcript": 'testing 4 5 6',
+ "confidence": 0.0123456


Sign in to view


 with self.assertRaises(ValueError):
- with _Monkey(MUT, SpeechApi=_MockGAPICSpeechAPI):
+ with _Monkey(_gax, SpeechApi=speech_api):


Sign in to view

+ self.assertEqual(results[1].transcript,
+ alternatives[1]['transcript'])
+ self.assertEqual(results[1].confidence,
+ alternatives[1]['confidence'])


dhermes

LGTM provided you clear up my most recent comments and resolve the setup.py question for @jonparrott

daspecster · 2016-11-03T20:37:52Z

Travis has gone on strike again...

daspecster · 2016-11-03T22:51:45Z

Finally travis ran this job. @dhermes, I'm merging(in 15minutes) since I got your suggestions in.

dhermes · 2016-11-03T23:00:33Z

Feel free to merge now

…apic Add speech async gapic

Add speech async gapic

daspecster added the api: speech Issues related to the Speech-to-Text API. label Nov 2, 2016

daspecster assigned tseaver and dhermes Nov 2, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2016

daspecster force-pushed the add-speech-async-gapic branch from 0e14c9d to 5078aa4Compare November 2, 2016 03:07

daspecster mentioned this pull request Nov 2, 2016
Re-factoring Speech operation to use the base class. #2664
Merged

daspecster force-pushed the add-speech-async-gapic branch 2 times, most recently from 54b981b to eb08066Compare November 2, 2016 04:10

daspecster mentioned this pull request Nov 2, 2016
Tracking Speech API development. #2522
Closed
14 tasks

daspecster force-pushed the add-speech-async-gapic branch from eb08066 to 46cd146Compare November 2, 2016 04:17

daspecster commented Nov 2, 2016
View reviewed changes

Comment threadspeech/setup.py Outdated
REQUIREMENTS = [
'google-cloud-core >= 0.20.0',
'grpcio >= 1.0.0, < 2.0dev',
'google-gax >= 0.14.1, < 0.15dev',
This comment was marked as spam.
Sign in to view

daspecster force-pushed the add-speech-async-gapic branch 2 times, most recently from 0ca8559 to bf805e3Compare November 2, 2016 04:49

dhermes reviewed Nov 2, 2016
View reviewed changes

daspecster force-pushed the add-speech-async-gapic branch from 375feeb to 2e9f486Compare November 2, 2016 18:20

dhermes reviewed Nov 3, 2016
View reviewed changes

daspecster added the PR: Needs to be squashed label Nov 3, 2016

dhermes reviewed Nov 3, 2016
View reviewed changes

Comment threadspeech/unit_tests/test_client.py Outdated
"confidence": 0.9224355
}, {
"transcript": 'testing 4 5 6',
"confidence": 0.0123456
This comment was marked as spam.
Sign in to view

dhermes reviewed Nov 3, 2016
View reviewed changes

Comment threadspeech/unit_tests/test_client.py Outdated

with self.assertRaises(ValueError):
with _Monkey(MUT, SpeechApi=_MockGAPICSpeechAPI):
with _Monkey(_gax, SpeechApi=speech_api):
This comment was marked as spam.
Sign in to view

dhermes reviewed Nov 3, 2016
View reviewed changes

Comment threadspeech/unit_tests/test_client.py Outdated
self.assertEqual(results[1].transcript,
alternatives[1]['transcript'])
self.assertEqual(results[1].confidence,
alternatives[1]['confidence'])
This comment was marked as spam.
Sign in to view

dhermes approved these changes Nov 3, 2016
View reviewed changes

Add speech async GAPIC.
5d4272f

daspecster force-pushed the add-speech-async-gapic branch from 77b6d16 to 5d4272fCompare November 3, 2016 18:52

daspecster removed the PR: Needs to be squashed label Nov 3, 2016

daspecster merged commit 3de5bc0 into googleapis:masterNov 3, 2016

daspecster mentioned this pull request Nov 3, 2016
Speech unit tests cleanup. #2676
Merged

daspecster mentioned this pull request Nov 9, 2016
Add async support to Speech API #2384
Closed

dhermes mentioned this pull request Nov 14, 2016
Upgrading core to version to 0.21.0. #2733
Merged

daspecster mentioned this pull request Nov 29, 2016
Add support for query parameters #2776
Merged

daspecster deleted the add-speech-async-gapic branch January 24, 2017 15:17

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Merge pull requestgoogleapis#2663from daspecster/add-speech-async-g…
1b209fd
…apic Add speech async gapic

theacodes unassigned dhermes Sep 28, 2018

atulep pushed a commit that referenced this pull request Apr 3, 2023
Merge pull request#2663from daspecster/add-speech-async-gapic
64537ed
Add speech async gapic

atulep pushed a commit that referenced this pull request Apr 18, 2023
Merge pull request#2663from daspecster/add-speech-async-gapic
f3bbb9a
Add speech async gapic

parthea pushed a commit that referenced this pull request Oct 22, 2023
Merge pull request#2663from daspecster/add-speech-async-gapic
5aa40c0
Add speech async gapic

Uh oh!

Conversation

daspecster commented Nov 2, 2016• edited by dhermes Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

daspecster commented Nov 2, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

daspecster commented Nov 3, 2016

Uh oh!

daspecster commented Nov 3, 2016

Uh oh!

dhermes commented Nov 3, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

daspecster commented Nov 2, 2016•
edited by dhermes
Loading