Add stability information to streaming results. by daspecster · Pull Request #2714 · googleapis/google-cloud-python

daspecster · 2016-11-10T16:33:40Z

Towards #2522.

This changes the surface, since is_final and stability are per-result and not a per-alternative.

dhermes

I started out 👎 on the new class but it seems "necessary" in some sense. The only other alternative would be to return a tuple with all the data

results, stability, is_final

But maybe I am not grokking the interface correctly

Sign in to view

+ >>> print(results[0].alternatives[0].transcript)
 hello
- >>> print(alternatives[0].confidence)
+ >>> print(results[0].alternatives[0].confidence)


Sign in to view

 profanity_filter, speech_context)


+class StreamingSpeechResult(object):


Sign in to view

+ """Streaming speech result representation.
+
+ :type alternatives: list
+ :param alternatives: List of protobuf speech alternatives.


Sign in to view

+ :param stability: 0.0-1.0 stability score for the results returned.
+
+ :rtype: :class:`~google.cloud.speech.client.StreamingSpeechResult`
+ :returns: Instance of ``StreamingSpeechResult``.


Sign in to view

+ """
+ def __init__(self, alternatives, is_final=False, stability=0.0):
+ self._alternatives = [Alternative.from_pb(alternative)
+ for alternative in alternatives]


Sign in to view

+
+ :type response: :class:`~google.cloud.grpc.speech.v1beta1\
+ .cloud_speech_pb2.StreamingRecognizeResult`
+ :param response: Istance of ``StreamingRecognizeResult`` protobuf.


Sign in to view

+ .cloud_speech_pb2.StreamingRecognizeResult`
+ :param response: Istance of ``StreamingRecognizeResult`` protobuf.
+
+ :rtype: :class:`~google.cloud.speech.client.StreamingSpeechResult`


Sign in to view

+ return self._alternatives
+
+ @property
+ def is_final(self):


Sign in to view

+ return self._is_final
+
+ @property
+ def stability(self):


Sign in to view

- self.assertEqual(results[0], [])
- self.assertEqual(results[1][0].transcript,
+
+ self.assertIsInstance(results[0], StreamingSpeechResult)


daspecster · 2016-11-10T19:37:38Z

I'm totally open to ideas(regarding StreamingSpeechResult class). I had this class in a previous branch, and from discussions before, it sounded like you were for bringing protobuf data into our own classes as an abstraction.

daspecster · 2016-11-10T23:46:46Z

@dhermes CircleCI is winning my love.

Did you have anything else for this?

dhermes · 2016-11-11T06:54:29Z

You also forgot to check in a new RST file for result.py

dhermes · 2016-11-11T06:57:12Z

LGTM once you fix your b0rken docs situation

daspecster · 2016-11-11T15:09:36Z

Everything went green. Squashed and I'll just make sure it goes green again and then I'll merge.

…peech-results Add stability information to streaming results.

Add stability information to streaming results.

* Add initial Secret Manager samples [(#2664)](GoogleCloudPlatform/python-docs-samples#2664) * Bump secretmanager version [(#2699)](GoogleCloudPlatform/python-docs-samples#2699) This bumps to the version that doesn't have a bunch of deprecation warnings. * Fix a small comment typo [(#2714)](GoogleCloudPlatform/python-docs-samples#2714) * Add Secret Manager IAM samples [(#2749)](GoogleCloudPlatform/python-docs-samples#2749) * Add Secret Manager IAM samples * Use an envvar for the iam user * Add env var to secrets. Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> * SecretManager update v1beta1->v1 [(#3065)](GoogleCloudPlatform/python-docs-samples#3065) Client library has been updated: https://pypi.org/project/google-cloud-secret-manager/ * Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-samples#2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: some lint fixes [(#3749)](GoogleCloudPlatform/python-docs-samples#3749) * chore(deps): update dependency google-cloud-secret-manager to v1 [(#3846)](GoogleCloudPlatform/python-docs-samples#3846) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-cloud-secret-manager](https://togithub.com/googleapis/python-secret-manager) | major | `==0.2.0` -> `==1.0.0` | --- ### Release Notes <details> <summary>googleapis/python-secret-manager</summary> ### [`v1.0.0`](https://togithub.com/googleapis/python-secret-manager/blob/master/CHANGELOG.md#100-httpswwwgithubcomgoogleapispython-secret-managercomparev020v100-2020-05-20) [Compare Source](https://togithub.com/googleapis/python-secret-manager/compare/v0.2.0...v1.0.0) ##### Features - release as production/stable ([#24](https://www.github.com/googleapis/python-secret-manager/issues/24)) ([39a8cc8](https://www.github.com/googleapis/python-secret-manager/commit/39a8cc8f631569c82d1cbffc6a9bbb440d380683)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * Replace GCLOUD_PROJECT with GOOGLE_CLOUD_PROJECT. [(#4022)](GoogleCloudPlatform/python-docs-samples#4022) * chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloudPlatform/python-docs-samples#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <coleleah@google.com> * Update dependency pytest to v6 [(#4390)](GoogleCloudPlatform/python-docs-samples#4390) * chore: update templates Co-authored-by: Seth Vargo <seth@sethvargo.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> Co-authored-by: gwhitehawk <gwhitehawk@gmail.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> Co-authored-by: Leah Cole <coleleah@google.com>

Add stability information to streaming results.

daspecster added the api: speech Issues related to the Speech-to-Text API. label Nov 10, 2016

daspecster assigned tseaver and dhermes Nov 10, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2016

daspecster force-pushed the add-stability-to-speech-results branch from 7fb59d4 to 9f2c34eCompare November 10, 2016 18:04

dhermes reviewed Nov 10, 2016
View reviewed changes

daspecster force-pushed the add-stability-to-speech-results branch from 25aad88 to 71a0d55Compare November 11, 2016 13:54

Add stability information to streaming results.Fixesgoogleapis#2702.
38e0887

daspecster force-pushed the add-stability-to-speech-results branch from 71a0d55 to 38e0887Compare November 11, 2016 15:09

daspecster merged commit f364416 into googleapis:masterNov 11, 2016

daspecster deleted the add-stability-to-speech-results branch November 11, 2016 15:45

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Merge pull requestgoogleapis#2714from daspecster/add-stability-to-s…
a872295
…peech-results Add stability information to streaming results.

theacodes unassigned dhermes Sep 28, 2018

atulep pushed a commit that referenced this pull request Apr 3, 2023
Merge pull request#2714from daspecster/add-stability-to-speech-results
28627f2
Add stability information to streaming results.

atulep pushed a commit that referenced this pull request Apr 18, 2023
Merge pull request#2714from daspecster/add-stability-to-speech-results
045abc2
Add stability information to streaming results.

parthea pushed a commit that referenced this pull request Oct 22, 2023
Merge pull request#2714from daspecster/add-stability-to-speech-results
e41c03e
Add stability information to streaming results.

		profanity_filter, speech_context)


		class StreamingSpeechResult(object):

Uh oh!

Conversation

daspecster commented Nov 10, 2016

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

daspecster commented Nov 10, 2016

Uh oh!

daspecster commented Nov 10, 2016

Uh oh!

dhermes commented Nov 11, 2016

Uh oh!

dhermes commented Nov 11, 2016

Uh oh!

daspecster commented Nov 11, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants