Skip to content

Add Flask Helper to Error Reporting - #2751

Merged
dhermes merged 1 commit into
googleapis:masterfrom
waprin:flask_errors
Dec 1, 2016
Merged

Add Flask Helper to Error Reporting#2751
dhermes merged 1 commit into
googleapis:masterfrom
waprin:flask_errors

Conversation

@waprin

@waprinwaprin commented Nov 17, 2016

Copy link
Copy Markdown
Contributor

cc / @steren

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2016
@daspecster

daspecster commented Nov 18, 2016

Copy link
Copy Markdown
Contributor

@waprin was this ready for review? I know there are no assignees, but there's also no "Don't merge" label.

dhermes
dhermes reviewed Nov 18, 2016
View reviewed changes
Comment threaddocs/error-reporting-usage.rst Outdated
>>> client = error_reporting.Client()
>>> client.report_exception(
>>> http_context=build_flask_context(request))
>>> # rest of error response code here

This comment was marked as spam.

Sign in to view

Comment threaddocs/error-reporting-usage.rst Outdated

.. code-block:: python

>>> @app.errorhandler(Exception)

This comment was marked as spam.

Sign in to view

Comment threaddocs/error-reporting-usage.rst Outdated
.. code-block:: python

>>> @app.errorhandler(Exception)
>>> def handle_error(e):

This comment was marked as spam.

Sign in to view

Comment threaddocs/error-reporting-usage.rst Outdated

>>> @app.errorhandler(Exception)
>>> def handle_error(e):
>>> client = error_reporting.Client()

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/google/cloud/error_reporting/__init__.py Outdated

"""Client library for Stackdriver Error Reporting"""

from google.cloud.error_reporting.client import Client, HTTPContext

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/unit_tests/__init__.py Outdated
# See the License for the specific language governing permissions and
# limitations under the License.


This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/unit_tests/test_client.py Outdated
self.assertLess(report_location['lineNumber'], 150)


class TestFlaskHelper(unittest.TestCase):

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/unit_tests/test_client.py Outdated

def test_flask_helper(self):
from google.cloud.error_reporting import build_flask_context
request = _Request('http://google.com', 'GET',

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/unit_tests/test_client.py Outdated

class TestFlaskHelper(unittest.TestCase):

def test_flask_helper(self):

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/unit_tests/test_client.py Outdated
self.assertEqual(request.remote_addr, context.remoteIp)


# Fake request so no need to bring in Werkzeug as dependency

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Nov 21, 2016
View reviewed changes
Comment threaderror_reporting/google/cloud/error_reporting/util.py
from google.cloud.error_reporting.client import HTTPContext


def build_flask_context(request):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/google/cloud/error_reporting/__init__.py
referrer=request.referrer,
remote_ip=request.remote_addr)
from google.cloud.error_reporting.client import Client
from google.cloud.error_reporting.client import HTTPContext

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/unit_tests/test_util.py Outdated
import unittest


class TestFlaskHelper(unittest.TestCase):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/unit_tests/test_util.py Outdated

def test_flask_helper(self):
from google.cloud.error_reporting.util import build_flask_context
user_agent = _UserAgent('Google Cloud Unit Tests Agent')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/unit_tests/test_util.py
class TestFlaskHelper(unittest.TestCase):

def test_flask_helper(self):
from google.cloud.error_reporting.util import build_flask_context

This comment was marked as spam.

Sign in to view

@waprin
waprinforce-pushed the flask_errors branch 3 times, most recently from 57b1a0e to 27f7917CompareNovember 22, 2016 22:03
@waprin

waprin commented Nov 22, 2016

Copy link
Copy Markdown
ContributorAuthor

@dhermes ping whenever is convenient. hit most review comments but wasn't sure about test class naming conventions, looked at a few and didn't seen an obvious consistency I was breaking.

dhermes
dhermes reviewed Nov 23, 2016
View reviewed changes
Comment threaderror_reporting/google/cloud/error_reporting/util.py
from google.cloud.error_reporting.client import HTTPContext


def build_flask_context(request):

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/unit_tests/test_util.py Outdated
import unittest


class TestFlaskHelper(unittest.TestCase):

This comment was marked as spam.

Sign in to view

Comment threaddocs/error-reporting-util.rst Outdated
@@ -0,0 +1,6 @@
Error Reporting Client

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threaddocs/error-reporting-usage.rst Outdated

.. code-block:: python

>>> from google.cloud.error_reporting.util import build_flask_context

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/google/cloud/error_reporting/__init__.py

"""Client library for Stackdriver Error Reporting"""


This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threaderror_reporting/tox.ini Outdated
deps =
{toxinidir}/../core
{toxinidir}/../logging
{toxinidir}/../logging

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@waprin
waprinforce-pushed the flask_errors branch 3 times, most recently from d4402c5 to a7e7accCompareNovember 23, 2016 20:25
@waprin

waprin commented Dec 1, 2016

Copy link
Copy Markdown
ContributorAuthor

@dhermes merge?

@dhermes
dhermes merged commit 7b74630 into googleapis:masterDec 1, 2016
@dhermesdhermes added api: clouderrorreporting Issues related to the Error Reporting API. and removed api: clouderrorreporting Issues related to the Error Reporting API. labels Feb 23, 2017
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull requestgoogleapis#2751from waprin/flask_errors
d8a3e8b
Add Flask Helper to Error Reporting
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@daspecsterdaspecsterdaspecster left review comments
@dhermesdhermesdhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: clouderrorreportingIssues related to the Error Reporting API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@waprin@daspecster@dhermes@googlebot