datastore: Support decoding empty arrays

[udoprog]

When the array_value is empty, the set also becomes empty which triggers the existing condition len(exclude_values) != 0.

This patch changes this condition to permit empty array values to pass through.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[udoprog]

I signed it!

[googlebot]

CLAs look good, thanks!

[dhermes]

@udoprog Can you give an example that currently fails, but would work under the changes in this PR?

[udoprog]

The python client doesn't permit writing an empty array, so you'll have to do that using another client (we do it using Java).

Or, go into the cloud console and add an entity /test:test with an Array property that has the following value:

{
"values": []
}

After this, run the following code:

fromgoogle.cloudimportdatastoreif__name__=="__main__":
client=datastore.Client('my-project-1')
k=client.key('test', 'test')
e=client.get(k)
print(e)

Without this patch, you should see:

Traceback (most recent call last):
File "example.py", line 9, in <module>
e = client.get(k)
File "/home/udoprog/.local/lib/python3.5/site-packages/google/cloud/datastore/client.py", line 256, in get
deferred=deferred, transaction=transaction)
File "/home/udoprog/.local/lib/python3.5/site-packages/google/cloud/datastore/client.py", line 316, in get_multi
for entity_pb in entity_pbs]
File "/home/udoprog/.local/lib/python3.5/site-packages/google/cloud/datastore/client.py", line 316, in <listcomp>
for entity_pb in entity_pbs]
File "/home/udoprog/.local/lib/python3.5/site-packages/google/cloud/datastore/helpers.py", line 142, in entity_from_protobuf
raise ValueError('For an array_value, subvalues must either '
ValueError: For an array_value, subvalues must either all be indexed or all excluded from indexes.

[dhermes]

Thanks @udoprog!

In order to actually merge this in, we'll need some unit tests. You can write them yourself, or I am happy to write them, since you've allowed maintainers to push commits to your PR branch.

[daspecster]

@dhermes won't google CLA bot wig out if multiple people commit?

[dhermes]

@daspecster It may, but we the humans can ignore it.

[udoprog]

My apologies I can't take a more active part in this right now. Feel free to just see this as a bug report and fix things whatever way suits you best.

[lukesneeringer]

See also #3152, where I attempted to fix this problem and hit another problem.

We likely do not need two issues for it, though, so I am closing this one.