Add system test for Vision Logo detection. by daspecster · Pull Request #2788 · googleapis/google-cloud-python

daspecster · 2016-11-30T23:19:12Z

Towards: #2753 and #2526.

I will add the filename test after #2778 is merged.
To get this kicked off though, here are some system tests for detect_logo().

dhermes

Mostly LG but a few changes are "needed"

Sign in to view

 TEST_MODULES = {
 'datastore': datastore,
 'speech': speech,
+ 'vision': vision,


Sign in to view

+ CLIENT = None
+ TEST_BUCKET = None
+
+ LOGO_FILE = os.path.join(os.path.dirname(__file__), 'data', 'logo.png')


Sign in to view

+ bucket_retry(Config.TEST_BUCKET.delete)(force=True)
+
+
+class TestSpeechClient(unittest.TestCase):


Sign in to view

+ value.delete()
+
+ def _assert_logo(self, logo):
+ self.assertEqual(logo.description, 'Google')


daspecster · 2016-12-02T18:39:55Z

I added the filename test as well.

system-tests runtests: commands[1] | python /Users/daspecster/Documents/google/google-cloud-python/system_tests/attempt_system_tests.py vision
test_detect_logos_content (vision.TestVisionClient) ... ok
test_detect_logos_filename (vision.TestVisionClient) ... ok
test_detect_logos_gcs (vision.TestVisionClient) ... ok
----------------------------------------------------------------------
Ran 3 tests in 5.540s
OK
____________________________________________________ summary _____________________________________________________
system-tests: commands succeeded
congratulations :)

daspecster · 2016-12-02T20:14:15Z

Squashed! And cancelled travis #SaveCycles.

…tests Add system test for Vision Logo detection.

daspecster added testing api: vision Issues related to the Cloud Vision API. labels Nov 30, 2016

daspecster assigned tseaver and dhermes Nov 30, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2016

daspecster mentioned this pull request Nov 30, 2016
Tracking Vision Development. #2753
Closed
10 tasks

dhermes reviewed Dec 1, 2016
View reviewed changes

daspecster force-pushed the vision-add-system-tests branch from bd0270b to c6019d8Compare December 2, 2016 18:38

dhermes approved these changes Dec 2, 2016
View reviewed changes

Add system test for Vision Logo detection.
e6ea013

daspecster force-pushed the vision-add-system-tests branch from c6019d8 to e6ea013Compare December 2, 2016 20:14

daspecster merged commit 1650979 into googleapis:masterDec 2, 2016

daspecster deleted the vision-add-system-tests branch December 2, 2016 20:42

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Merge pull requestgoogleapis#2788from daspecster/vision-add-system-…
6be983e
…tests Add system test for Vision Logo detection.

theacodes unassigned dhermes Sep 28, 2018

		bucket_retry(Config.TEST_BUCKET.delete)(force=True)


		class TestSpeechClient(unittest.TestCase):

Uh oh!

Conversation

daspecster commented Nov 30, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

daspecster commented Dec 2, 2016

Uh oh!

daspecster commented Dec 2, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daspecster commented Nov 30, 2016•
edited
Loading

daspecster commented Dec 2, 2016•
edited
Loading