Skip to content

Switch NL from v1beta1 to v1. Fixes #2747. - #2798

Merged
dhermes merged 2 commits into
googleapis:masterfrom
jmdobry:language-v1
Dec 3, 2016
Merged

Switch NL from v1beta1 to v1. Fixes #2747.#2798
dhermes merged 2 commits into
googleapis:masterfrom
jmdobry:language-v1

Conversation

@jmdobry

@jmdobryjmdobry commented Dec 2, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2016
dhermes
dhermes approved these changes Dec 2, 2016
View reviewed changes

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was easy! Thanks a lot

Comment threadlanguage/google/cloud/language/document.py Outdated
api_response = self.client._connection.api_request(
method='POST', path='analyzeSyntax', data=data)
return [Token.from_api_repr(token)
for token in api_response['tokens']]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadlanguage/unit_tests/test_document.py Outdated
'proper': 'PROPER',
'reciprocity': 'RECIPROCITY_UNKNOWN',
'tense': 'TENSE_UNKNOWN',
'voice': 'VOICE_UNKNOWN',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Dec 3, 2016

Copy link
Copy Markdown
Contributor

LGTM

@dhermes
dhermes merged commit a02ac50 into googleapis:masterDec 3, 2016
@jmdobry
jmdobry deleted the language-v1 branch December 3, 2016 03:14
@jmdobry

jmdobry commented Dec 5, 2016

Copy link
Copy Markdown
ContributorAuthor

Is there a set release schedule? What's the ETA on getting a new version of google-cloud-language published?

@dhermes

dhermes commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

I'll be releasing this afternoon, thanks for checking in

@dhermesdhermes mentioned this pull request Dec 5, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull requestgoogleapis#2798from jmdobry/language-v1
21e0d30
Switch NL from v1beta1 to v1. Fixesgoogleapis#2747.
parthea pushed a commit that referenced this pull request Jul 6, 2023
@dhermes
Merge pull request#2798from jmdobry/language-v1
48c75b1
Switch NL from v1beta1 to v1. Fixes#2747.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dhermesdhermesdhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmdobry@tseaver@dhermes@googlebot