Skip to content

Allow timestamp strings in 'Table.insert_data'. - #2805

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:1382-bigquery-table-insert_data-timestamp_strings
Dec 5, 2016
Merged

Allow timestamp strings in 'Table.insert_data'.#2805
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:1382-bigquery-table-insert_data-timestamp_strings

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Closes#1382.

@tseavertseaver added the api: bigquery Issues related to the BigQuery API. label Dec 5, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2016
rows_info = []
data = {'rows': rows_info}

def _convert_timestamp(value):

This comment was marked as spam.

@dhermes

Copy link
Copy Markdown
Contributor

@tseaver Easy enough change to review, ping me once new function is defined as a global

@tseaver

Copy link
Copy Markdown
ContributorAuthor

@dhermes ping

@tseaver
tseaver merged commit fdfb5a3 into googleapis:masterDec 5, 2016
@tseaver
tseaver deleted the 1382-bigquery-table-insert_data-timestamp_strings branch December 5, 2016 18:32
@shealutton

Copy link
Copy Markdown

Thanks! I needed exactly this change. Much obliged.

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
…nsert_data-timestamp_strings
Allow timestamp strings in 'Table.insert_data'.
plamut pushed a commit to googleapis/python-bigquery that referenced this pull request Feb 4, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tseaver@dhermes@shealutton@daspecster@googlebot