Skip to content

Force close logging handler. - #2851

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:plug-tempdir-leak-windows
Dec 12, 2016
Merged

Force close logging handler.#2851
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:plug-tempdir-leak-windows

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Allow tempdir cleanup to work as expected on Windows.

Allow tempdir cleanup to work as expected on Windows.
@tseavertseaver added api: logging Issues related to the Cloud Logging API. testing labels Dec 10, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2016
@tseaver
tseaver merged commit e0ccd73 into googleapis:masterDec 12, 2016
@tseaver
tseaver deleted the plug-tempdir-leak-windows branch December 12, 2016 13:54
@dhermes

Copy link
Copy Markdown
Contributor

Something very wrong with Python 3:

Happened after this merged, but I don't think it was caused by this PR

@daspecster

Copy link
Copy Markdown
Contributor

@dhermes yeah I've been looking into this but I haven't found the cause other than what's in the trace.

Let's chat about it here #2856.

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@dhermes@daspecster@googlebot