Uh oh!
There was an error while loading. Please reload this page.
Remove connection from base Client class - #2870
Merged
Merged
Conversation
dhermesforce-pushed
the
rm-connection-from-base
branch
from
December 15, 2016 08:32
b5d633c to
2c42b7cCompare| self._connection = self._connection_class( | ||
| credentials=credentials, http=http) | ||
| self._credentials = credentials | ||
| self._http = http |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
daspecster
commented
Dec 15, 2016
Contributor
I would assume you would want @tseaver to take a look too, but this looks pretty straight forward and LGTM. |
dhermes
commented
Dec 15, 2016
ContributorAuthor
@daspecster Yup I'll wait for @tseaver. Thanks |
This was referenced Dec 15, 2016
Merged
tseaver
reviewed
Dec 15, 2016
| def __init__(self, project=None, namespace=None, | ||
| credentials=None, http=None): | ||
| _ClientProjectMixin.__init__(self, project=project) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tseaver
reviewed
Dec 15, 2016
| :meth:`~httplib2.Http.request`. If not passed, an | ||
| ``http`` object is created that is bound to the | ||
| ``credentials`` for the current object. | ||
| """ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tseaver
approved these changes
Dec 15, 2016
This was referenced Dec 29, 2016
19 tasks
richkadel pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Remove connection from base Client class
parthea pushed a commit
that referenced
this pull request
Nov 24, 2025
Remove connection from base Client class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #2606. The idea behind this PR: we can drop support for
Connectionclasses on a package-by-package basis rather than all at once./cc @tseaver and @mckoss this will have teeny implications on downstream clients