Skip to content

Accept copy jobs with single 'sourceTable' config. - #2884

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:2882-bigquery-copyjob-w-single-source-table
Dec 28, 2016
Merged

Accept copy jobs with single 'sourceTable' config.#2884
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:2882-bigquery-copyjob-w-single-source-table

Conversation

@tseaver

@tseavertseaver commented Dec 19, 2016

Copy link
Copy Markdown
Contributor

Such jobs would be created via another client: we map that configuration onto a sequence of tables containing only the one item.

Closes: #2882.

@tseaver
Accept copy jobs with single 'sourceTable' config.
28d5c67
Such jobs would be created via another client: we map that configuration
onto a sequence of tables containing only the one item.
Closes: #2882.
@tseavertseaver added api: bigquery Issues related to the BigQuery API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 19, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2016
dhermes
dhermes reviewed Dec 19, 2016
View reviewed changes
Comment threadbigquery/google/cloud/bigquery/job.py Outdated
for source_config in config['sourceTables']:
source_configs = config.get('sourceTables')
if source_configs is None:
source_configs = [config['sourceTable']]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseavertseaver mentioned this pull request Dec 20, 2016
Closed
@dhermes

dhermes commented Dec 28, 2016

Copy link
Copy Markdown
Contributor

LGTM

@tseaver
tseaver merged commit d158cc7 into googleapis:masterDec 28, 2016
@tseaver
tseaver deleted the 2882-bigquery-copyjob-w-single-source-table branch December 28, 2016 22:19
@dhermesdhermes mentioned this pull request Feb 24, 2017
Merged
19 tasks
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@tseaver
Raise explicit KeyError for copy job resource w/o source table(s).
adcd54a
Addresses:
googleapis#2884 (comment)
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@tseaver
Merge pull requestgoogleapis#2884from tseaver/2882-bigquery-copyjob…
ae5931a
…-w-single-source-table
Accept copy jobs with single 'sourceTable' config.
plamut pushed a commit to googleapis/python-bigquery that referenced this pull request Feb 4, 2020
@tseaver
Raise explicit KeyError for copy job resource w/o source table(s).
06a54db
Addresses:
googleapis/google-cloud-python#2884 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daspecsterdaspecsterAwaiting requested review from daspecster
1 more reviewer
@dhermesdhermesdhermes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@dhermes@daspecster@googlebot