Add Parent Field to Resource Manager by waprin · Pull Request #2941 · googleapis/google-cloud-python

waprin · 2017-01-18T00:29:10Z

Fixes#2940 by including parent field in the update.

Sign in to view

 PROJECT_NUMBER = 12345678
 PROJECT_LABELS = {'env': 'prod'}
 PROJECT_LIFECYCLE_STATE = 'ACTIVE'
+ PARENT = {'type': 'organization', 'id': 433637338579}


Sign in to view

 client = self._require_client(client)

- data = {'name': self.name, 'labels': self.labels}
+ data = {}


dhermes

LGTM

Sign in to view

+ data = {
+ 'name': self.name,
+ 'labels': self.labels,
+ 'parent': self.parent


Sign in to view

 self.labels = resource.get('labels', {})
 self.status = resource['lifecycleState']
+ if 'parent' in resource:
+ self.parent = resource['parent']


Sign in to view

 'lifecycleState': 'DELETE_REQUESTED',
+ 'parent': {
+ 'type': 'organization',
+ 'id': '433637338579'


Sign in to view

+ 'parent': {
+ 'type': 'organization',
+ 'id': '433637338579'
+ }


dhermes · 2017-01-18T20:59:58Z

@waprin Don't merge until CI is green

* Add Parent Field to Resource Manager

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 18, 2017

Add Parent Field to Resource Manager
4741984

waprin force-pushed the add_parents branch from 1aedfff to 4741984Compare January 18, 2017 00:31

sir-buckyball reviewed Jan 18, 2017
View reviewed changes

make project id string
10431b5

daspecster added the api: cloudresourcemanager Issues related to the Resource Manager API. label Jan 18, 2017

daspecster reviewed Jan 18, 2017
View reviewed changes

Comment threadresource_manager/google/cloud/resource_manager/project.py Outdated
client = self._require_client(client)

data = {'name': self.name, 'labels': self.labels}
data = {}
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

daspemcter review
d68b4a4

daspecster assigned dhermes and tseaver Jan 18, 2017

dhermes approved these changes Jan 18, 2017
View reviewed changes

Bill Prin added 2 commits January 18, 2017 14:49

Dhermes review
f1c6bf2

trailing commas
bb2ba9b

waprin merged commit e9b503a into googleapis:masterJan 18, 2017

dhermes mentioned this pull request Feb 24, 2017
Upgrading all versions for umbrella release. #3068
Merged
19 tasks

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Add Parent Field to Resource Manager (googleapis#2941)
f0ed002
* Add Parent Field to Resource Manager

theacodes unassigned dhermes Sep 28, 2018

parthea pushed a commit that referenced this pull request Jun 4, 2023
Add Parent Field to Resource Manager (#2941)
626d935
* Add Parent Field to Resource Manager

Uh oh!

Conversation

waprin commented Jan 18, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jan 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants