Skip to content

Fix KeyError for unsupported annotation types. - #2961

Merged
daspecster merged 2 commits into
googleapis:masterfrom
daspecster:fix-key-error-for-unsupported-annotation
Jan 30, 2017
Merged

Fix KeyError for unsupported annotation types.#2961
daspecster merged 2 commits into
googleapis:masterfrom
daspecster:fix-key-error-for-unsupported-annotation

Conversation

@daspecster

@daspecsterdaspecster commented Jan 24, 2017

Copy link
Copy Markdown
Contributor

Fixes#2930.

@daspecsterdaspecster added the api: vision Issues related to the Cloud Vision API. label Jan 24, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 24, 2017
daspecster
daspecster commented Jan 24, 2017
View reviewed changes
Comment threadvision/google/cloud/vision/annotations.py Outdated
:rtype: :class:`~google.cloud.vision.annotations.Annotations`
:returns: An instance of ``Annotations`` with detection types loaded.
"""
for feature_type in response.keys():

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

@jonparrott@gguuss PTAL. (I can already image the bug reports: "where is my data")

@daspecster

daspecster commented Jan 25, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@dhermes the data isn't going to get loaded unless it's routed into the google-cloud-python objects/DTO's. If it's not a property on the Annotations class then it won't be returned.

@lukesneeringer

lukesneeringer commented Jan 26, 2017

Copy link
Copy Markdown
Contributor

I am all kinds of nervous about just dropping extra fields, but it looks like #2930 has already covered this ground. So, okay.

@daspecster

daspecster commented Jan 30, 2017

Copy link
Copy Markdown
ContributorAuthor

Bump!

@theacodes

theacodes commented Jan 30, 2017

Copy link
Copy Markdown
Contributor

This is fine with me. I believe this is what @gguuss had in mind - the data isn't there, but the library doesn't explode.

@daspecster

daspecster commented Jan 30, 2017

Copy link
Copy Markdown
ContributorAuthor

Thanks @jonparrott!

@daspecster
daspecster merged commit f822e44 into googleapis:masterJan 30, 2017
@daspecster
daspecster deleted the fix-key-error-for-unsupported-annotation branch January 30, 2017 22:20
@daspecsterdaspecster mentioned this pull request Feb 24, 2017
Merged
19 tasks
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Fix KeyError for unsupported annotation types. (googleapis#2961)
eda8aac
* Fix KeyError for unsupported annotation types.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@daspecster
Fix KeyError for unsupported annotation types. (#2961)
1524fec
* Fix KeyError for unsupported annotation types.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@tseavertseavertseaver left review comments
@theacodestheacodestheacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tseavertseaver

Labels

api: visionIssues related to the Cloud Vision API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@daspecster@dhermes@lukesneeringer@theacodes@tseaver@googlebot