Skip to content

Move dryRun property to from query to configuration level. - #2984

Merged
daspecster merged 2 commits into
googleapis:masterfrom
daspecster:fix-bigquery-dry-run
Feb 6, 2017
Merged

Move dryRun property to from query to configuration level.#2984
daspecster merged 2 commits into
googleapis:masterfrom
daspecster:fix-bigquery-dry-run

Conversation

@daspecster

@daspecsterdaspecster commented Feb 6, 2017

Copy link
Copy Markdown
Contributor

Fixes#2981

Sets dryRun at ['configuration']['dryRun'] rather than ['configuration']['query']['dryRun].

@daspecsterdaspecster added api: bigquery Issues related to the BigQuery API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 6, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2017
@dhermes

dhermes commented Feb 6, 2017

Copy link
Copy Markdown
Contributor

I'll defer to @tseaver here

tseaver
tseaver suggested changes Feb 6, 2017
View reviewed changes
Comment threadbigquery/google/cloud/bigquery/query.py
Values which are ``None`` -> server defaults.
"""
_default_dataset = None
_dry_run = None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadbigquery/unit_tests/test_query.py
query.timeout_ms = 20000
query.use_query_cache = False
query.use_legacy_sql = True
query.dry_run = True

This comment was marked as spam.

Sign in to view

@daspecster
daspecster removed the request for review from dhermesFebruary 6, 2017 17:48
@daspecster
daspecster merged commit ec1776c into googleapis:masterFeb 6, 2017
@daspecster
daspecster deleted the fix-bigquery-dry-run branch February 6, 2017 18:24
@dhermesdhermes mentioned this pull request Feb 24, 2017
Merged
19 tasks
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Move dryRun property to from query to configuration level. (googleapi…
90f1447
…s#2984)
* Move dryRun property to from query to configuration level.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@tseavertseavertseaver approved these changes
@lukesneeringerlukesneeringerlukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@daspecster@dhermes@lukesneeringer@tseaver@googlebot