Skip to content

Add create_resumable_upload_session - #2989

Merged
theacodes merged 6 commits into
googleapis:masterfrom
theacodes:storage-resumable
Feb 9, 2017
Merged

Add create_resumable_upload_session#2989
theacodes merged 6 commits into
googleapis:masterfrom
theacodes:storage-resumable

Conversation

@theacodes

@theacodestheacodes commented Feb 9, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves#1240

(Aside: wow this code is complicated)

@theacodestheacodes added the api: storage Issues related to the Cloud Storage API. label Feb 9, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 9, 2017
@theacodestheacodes changed the title Storage resumableAdd create_resumable_upload_sessionFeb 9, 2017
lukesneeringer
lukesneeringer reviewed Feb 9, 2017
View reviewed changes
Comment threadstorage/google/cloud/storage/blob.py
headers = {
'Accept': 'application/json',
'Accept-Encoding': 'gzip, deflate',
'User-Agent': connection.USER_AGENT,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes

theacodes commented Feb 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@dhermes or @tseaver do either of you want to take a look at this before I merge?

@dhermes

dhermes commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

I have lots of faith in @lukesneeringer

@theacodes

theacodes commented Feb 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@lukesneeringer tests are failing because of the operations/protobuf issue? any recommendations?

@lukesneeringer

lukesneeringer commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

I know what needs to happen here; it is related to googleapis/api-client-staging#159.
I will have an update in half an hour.

@lukesneeringer

lukesneeringer commented Feb 9, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

I assert that this commit on googleapis/api-client-staging#159 fixes the issue; attempting tests locally to prove it before cutting a release to PyPI.

@lukesneeringerlukesneeringer mentioned this pull request Feb 9, 2017
Merged
@lukesneeringer

lukesneeringer commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

@jonparrott I merged that other PR and pushed it to PyPI; your tests should pass now (or if they fail, it will be for other reasons ;-)).

@daspecster

daspecster commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

I restarted the build.

@daspecster

daspecster commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

Seems to have done the trick!

@theacodes
theacodes merged commit 9619004 into googleapis:masterFeb 9, 2017
@theacodes
theacodes deleted the storage-resumable branch February 9, 2017 23:55
@daspecsterdaspecster mentioned this pull request Feb 24, 2017
Merged
19 tasks
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Jon Wayne Parrott
Add create_resumable_upload_session (googleapis#2989)
57f4c09
parthea pushed a commit that referenced this pull request Mar 9, 2026
Jon Wayne Parrott
Add create_resumable_upload_session (#2989)
2eb2636
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lukesneeringerlukesneeringerlukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theacodes@dhermes@lukesneeringer@daspecster@googlebot