Remove cyclic import from ignored for tests. by dhermes · Pull Request #302 · googleapis/google-cloud-python

dhermes · 2014-10-28T00:01:42Z

It may be worth adding a script to check that our pylint configs don't get out of sync.

I hastily hacked together:
https://gist.github.com/dhermes/8516afb92d14fdc38cb6

tseaver · 2014-10-28T00:07:05Z

LGTM.

coveralls · 2014-10-28T00:13:46Z

Coverage remained the same when pulling 7d27e5c on dhermes:remove-cyclic-twice into d094d30 on GoogleCloudPlatform:master.

dhermes · 2014-10-28T00:14:15Z

@tseaver WDYT about adding a check to make sure they stay in sync?

tseaver · 2014-10-28T02:13:58Z

I don't know pylint well, but the best way to manage that would be to DRY one file as a delta to another.

coveralls · 2014-10-28T04:17:11Z

Coverage remained the same when pulling 94d9646 on dhermes:remove-cyclic-twice into e1fd94f on GoogleCloudPlatform:master.

dhermes · 2014-10-28T06:38:19Z

@tseaver I gave it a spin with ConfigParser. PTAL.

coveralls · 2014-10-28T06:46:11Z

Coverage remained the same when pulling da28005 on dhermes:remove-cyclic-twice into e1fd94f on GoogleCloudPlatform:master.

Sign in to view

Uses ConfigParser to append modifications onto base file and writes a new config file (which is gitignore-ed) before running pylint.

dhermes · 2014-10-28T20:14:30Z

@tseaver I implemented the pragmatic approach we discussed and rebased on top of master. PTAL

tseaver · 2014-10-28T20:15:30Z

LGTM, pending Travis.

coveralls · 2014-10-28T20:35:27Z

Changes Unknown when pulling d75091a on dhermes:remove-cyclic-twice into * on GoogleCloudPlatform:master*.

Remove cyclic import from ignored for tests.

Now get_message allows to specify an object_id and expands or selects as well.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@7ff4aad Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:462782b0b492346b2d9099aaff52206dd30bc8e031ea97082e6facecc2373244

Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: regenerate API index Source-Link: googleapis/googleapis@40a03de Source-Link: googleapis/googleapis-gen@6c17328 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmMxNzMyOGU5ZTFjMmI1OGU5NjAwNzIyZThmYzhjYmU4NDYwMGQ3ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: update Java and Python dependencies PiperOrigin-RevId: 408420890 Source-Link: googleapis/googleapis@2921f9f Source-Link: googleapis/googleapis-gen@6598ca8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjU5OGNhOGNiYmY1MjI2NzMzYTA5OWM0NTA2NTE4YTVhZjZmZjc0YyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9

Source-Link: googleapis/synthtool@050953d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. fix: improper types in pagers generation PiperOrigin-RevId: 399773015 Source-Link: googleapis/googleapis@410c184 Source-Link: googleapis/googleapis-gen@290e883 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwZTg4MzU0NWUzYWM5ZmYyYmQwMGNkMGRhY2IyOGYxYjhjYTk0NSJ9

Source-Link: googleapis/synthtool@06e8279 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b3500c053313dc34e07b1632ba9e4e589f4f77036a7cf39e1fe8906811ae0fce

…lossary (#302)

…302) - [ ] Regenerate this pull request now. feat: add `tokens_per_project_per_hour` field to `PropertyQuota` type PiperOrigin-RevId: 479394249 Source-Link: https://togithub.com/googleapis/googleapis/commit/59b73bd6f7c00dc5af895414c444b08055849bdf Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c2f211bcb3cc0b10cb71905185dd740bd26fc372 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzJmMjExYmNiM2NjMGIxMGNiNzE5MDUxODVkZDc0MGJkMjZmYzM3MiJ9

* docs: removed default model comment and added comment to test * fix: backoff on predict_test.py * fix: backoff on predict_test.py * fix: added backoff to predict_test.py * fix: added backoff to predict_test.py * fix: added backoff to predict_test.py

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* feat: enable "rest" transport in Python for services supporting numeric enums PiperOrigin-RevId: 508143576 Source-Link: googleapis/googleapis@7a702a9 Source-Link: googleapis/googleapis-gen@6ad1279 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.8.5 PiperOrigin-RevId: 511892190 Source-Link: googleapis/googleapis@a45d9c0 Source-Link: googleapis/googleapis-gen@1907294 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

Source-Link: googleapis/synthtool@0142f35 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:99ab465187b4891e878ee4f9977b4a6aeeb0ceadf404870c416c50e06500eb42 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* CLN: remove deprecated private_key auth logic * remove unnecessary deprecation warning for private_key * update docstrings for deprecated private_key arg

chore: add SECURITY.md

Nested message definitions may have fields that are types defined in other modules. These modules need to be imported into the module that defines the nested message def. Ancillary changes, useful for debugging, development, and testing: * generate.py can be used standalone without being invoked by protoc * Specific testfiles and tests can be passed to pytest via the noxfile

dir(proto.Message) defaults to dir(type)

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.2](https://www.github.com/googleapis/python-api-core/compare/v2.2.1...v2.2.2) (2021-11-02) ### Bug Fixes * make 'gapic_v1.method.DEFAULT' a typed object ([#292](https://www.github.com/googleapis/python-api-core/issues/292)) ([ffc51f0](https://www.github.com/googleapis/python-api-core/commit/ffc51f03c7ce5d9f009ba859b8df385d52925578)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore: use gapic-generator-python 0.65.1 PiperOrigin-RevId: 441524537 Source-Link: googleapis/googleapis@2a27391 Source-Link: googleapis/googleapis-gen@ab6756a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWI2NzU2YTQ4Yzg5YjViY2I5ZmI3MzQ0M2NiOGU1NWQ1NzRmNDY0MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@bd9ede2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:04c35dc5f49f0f503a306397d6d043685f8d2bb822ab515818c4208d7fb2db3a Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: manual synth * Updated synth to preserve .make gitignore Co-authored-by: Craig Labenz <craiglabenz@google.com>

gcr.io/repo-automation-bots/owlbot-python:latest@sha256:4c981a6b6f2b8914a448d7b3a01688365be03e3ed26dfee399a6aa77fb112eaa

The wrapper, `_remote.RemoteCall`, added to help attach debugging into to gRPC calls, inadvertantly introduced a race condition between the gRPC thread and the NDB thread, where the gRPC thread might call `RemoteCall._finish` *during* a call to `RemoteCall.add_done_callback`. The solution, here, is to turn `RemoteCall.add_done_callback` into a direct pass-through to `grpc.Future.add_done_callback` on the wrapped future. The callback which is eventually executed in the gRPC thread, only pushes the finished RPC onto a `queue.Queue` which is eventually consumed by the event loop running in the NDB thread. Fixes#302.

gcr.io/repo-automation-bots/owlbot-python:latest@sha256:4c981a6b6f2b8914a448d7b3a01688365be03e3ed26dfee399a6aa77fb112eaa

Clean up temp files at exit.

Closes#181. **PR checklist:** - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-pubsub/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary)

Fixes#302

* chore(main): release 2.0.4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

dhermes force-pushed the remove-cyclic-twice branch from 7d27e5c to 94d9646Compare October 28, 2014 04:06

dhermes added hygiene testing labels Oct 28, 2014

tseaver reviewed Oct 28, 2014
View reviewed changes

Comment threadrun_pylint.py Outdated
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

dhermes added 3 commits October 28, 2014 12:57

Remove cyclic import from ignored for tests.
90c5ce2

Reducing repeated pylint configs by defining test configs as a delta.
8925aed
Uses ConfigParser to append modifications onto base file and writes a new config file (which is gitignore-ed) before running pylint.

Putting pylint additions for tests into run_pylint.
d75091a

dhermes force-pushed the remove-cyclic-twice branch from da28005 to d75091aCompare October 28, 2014 20:14

dhermes added a commit that referenced this pull request Oct 28, 2014
Merge pull request#302from dhermes/remove-cyclic-twice
87cf71d
Remove cyclic import from ignored for tests.

dhermes merged commit 87cf71d into googleapis:masterOct 28, 2014

dhermes deleted the remove-cyclic-twice branch October 28, 2014 20:39

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
Fixgoogleapis#302
dd6f33b
Now get_message allows to specify an object_id and expands or selects as well.

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
Fixgoogleapis#302again. Missed the initial check
0546c9d

atulep pushed a commit that referenced this pull request Apr 3, 2023
chore(main): release 2.12.0 (#302)
a73a7af
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023
chore(main): release 2.12.0 (#302)
cd2905d
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023
chore(main): release 2.12.0 (#302)
1f81e02
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 18, 2023
chore(main): release 2.12.0 (#302)
a7d774a
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(main): release 1.10.0 (#302)
2302f8a
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023
chore(deps): update dependency google-cloud-pubsub to v2.11.0 (#302)
4d00b8a

parthea pushed a commit that referenced this pull request Sep 22, 2023
chore(main): release 2.12.1 (#302)
8feed3b
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Oct 21, 2023
chore: test minimum dependencies in python 3.7 (#302)
97d6b62

parthea pushed a commit that referenced this pull request Oct 21, 2023
fix: 290 added a create glossary line before each call using bistro-g…
9036860
…lossary (#302)

parthea pushed a commit that referenced this pull request Oct 22, 2023
chore(main): release 2.12.0 (#302)
9d150c0
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 18, 2025
CLN: remove deprecatedprivate_keyauth logic (#302)
1d0b558
* CLN: remove deprecated private_key auth logic * remove unnecessary deprecation warning for private_key * update docstrings for deprecated private_key arg

parthea pushed a commit that referenced this pull request Nov 22, 2025
chore: add SECURITY.md (#302)
26bc832
chore: add SECURITY.md

parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: dir(proto.Message) does not raise (#302)
4dcc8b2
dir(proto.Message) defaults to dir(type)

parthea pushed a commit that referenced this pull request Nov 24, 2025
chore: manual synth (#302)
0346f25
* chore: manual synth * Updated synth to preserve .make gitignore Co-authored-by: Craig Labenz <craiglabenz@google.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025
chore: new owl bot post processor docker image (#302)
b673b71
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:4c981a6b6f2b8914a448d7b3a01688365be03e3ed26dfee399a6aa77fb112eaa

parthea pushed a commit that referenced this pull request Nov 25, 2025
chore: new owl bot post processor docker image (#302)
af9a225
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:4c981a6b6f2b8914a448d7b3a01688365be03e3ed26dfee399a6aa77fb112eaa

parthea pushed a commit that referenced this pull request Nov 26, 2025
Update trampoline.sh (#302)
1548bef
Clean up temp files at exit.

parthea pushed a commit that referenced this pull request Mar 6, 2026
django: skip serializers tests that fail from non-null AutoField
0db5f78
Fixes#302

Uh oh!

Conversation

dhermes commented Oct 28, 2014

Uh oh!

tseaver commented Oct 28, 2014

Uh oh!

coveralls commented Oct 28, 2014

Uh oh!

dhermes commented Oct 28, 2014

Uh oh!

tseaver commented Oct 28, 2014

Uh oh!

coveralls commented Oct 28, 2014

Uh oh!

dhermes commented Oct 28, 2014

Uh oh!

coveralls commented Oct 28, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 28, 2014

Uh oh!

tseaver commented Oct 28, 2014

Uh oh!

coveralls commented Oct 28, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants