Uh oh!
There was an error while loading. Please reload this page.
Adding ability to send version info header on HTTP requests. - #3035
Merged
Conversation
3 tasks
Added an "extra headers" feature to enable this. I am not a fan of changing `Connection()` so haphazardly, but I hope to completely re-factor / destory `Connection()` in the near-term so I am less worried. This only adds the storage and datastore header info, for the purposes of a simple review. Once we agree on the approach, I can add support in the other subpackages.
tseaver
reviewed
Feb 17, 2017
| _USE_GRPC = _HAVE_GRPC and not _DISABLE_GRPC | ||
| _DATASTORE_DIST = get_distribution('google-cloud-datastore') | ||
| _CLIENT_INFO = connection_module.CLIENT_INFO_TEMPLATE.format( | ||
| _DATASTORE_DIST.version) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tseaver
approved these changes
Feb 20, 2017
dhermes
commented
Feb 20, 2017
ContributorAuthor
Thanks @tseaver. Will hold off for @lukesneeringer review before merging |
lukesneeringer
approved these changes
Feb 21, 2017
lukesneeringer
left a comment
Contributor
There was a problem hiding this comment.
This looks fine to me. I am not clear how the where the handling for the gccl segment is when something is using GAX. I assume that is in a different PR.
dhermes
commented
Feb 21, 2017
ContributorAuthor
Will follow up with a PR for all other HTTP impls and then a separate PR getting this to work with GAPIC generated surfaces |
This was referenced Feb 21, 2017
richkadel pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Adding ability to send version info header on HTTP requests.
parthea pushed a commit
that referenced
this pull request
Nov 24, 2025
Adding ability to send version info header on HTTP requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an "extra headers" feature to enable this. I am not a fan
of changing
Connection()so haphazardly, but I hope tocompletely re-factor / destory
Connection()in the near-termso I am less worried.
This only adds the storage and datastore header info, for the
purposes of a simple review. Once we agree on the approach,
I can add support in the other subpackages.