Moving datastore GAX/gRPC helpers out of _http and into dedicated module. by dhermes · Pull Request #3036 · googleapis/google-cloud-python

dhermes · 2017-02-17T03:19:05Z

This leaves _http.py closer to what it should look like, but not all the way there (it is doing some of the transport choosing that should be done in client.py)

Sign in to view

@@ -0,0 +1,197 @@
+# Copyright 2014 Google Inc.


Sign in to view

+
+@contextlib.contextmanager
+def _grpc_catch_rendezvous():
+ """Re-map gRPC exceptions that happen in context.


…ule.

dhermes · 2017-02-17T16:35:37Z

@daspecster I folded those changes into the original commit (since they were super tiny)

daspecster · 2017-02-17T17:57:14Z

SGTM! Thanks! I know they were nitpicky.

The rest LGTM but I feel like someone else should take a crack at it.

Sign in to view

 try:
- from grpc import StatusCode
-from google.cloud.grpc.datastore.v1 import datastore_pb2_grpc
+ from google.cloud.datastore._gax import _DatastoreAPIOverGRPC


Sign in to view

- from grpc import StatusCode
-from google.cloud.grpc.datastore.v1 import datastore_pb2_grpc
+ from google.cloud.datastore._gax import _DatastoreAPIOverGRPC
+_HAVE_GRPC = True


Sign in to view

+ yield
+ except exceptions.GrpcRendezvous as exc:
+ error_code = exc.code()
+ error_class = _GRPC_ERROR_MAPPING.get(error_code)


Sign in to view

- from grpc import StatusCode
-from google.cloud.grpc.datastore.v1 import datastore_pb2_grpc
+ from google.cloud.datastore._gax import _DatastoreAPIOverGRPC
+_HAVE_GRPC = True


Moving datastore GAX/gRPC helpers out of _http and into dedicated module.

dhermes added api: datastore Issues related to the Datastore API. hygiene labels Feb 17, 2017

dhermes assigned lukesneeringer, daspecster and tseaver Feb 17, 2017

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2017

daspecster reviewed Feb 17, 2017
View reviewed changes

Moving datastore GAX/gRPC helpers out of _http and into dedicated mod…
0109bbd
…ule.

dhermes force-pushed the give-datastore-gax branch from ebeb2e7 to 0109bbdCompare February 17, 2017 16:35

tseaver reviewed Feb 17, 2017
View reviewed changes

lukesneeringer reviewed Feb 21, 2017
View reviewed changes

lukesneeringer approved these changes Feb 21, 2017
View reviewed changes

dhermes merged commit 0cb9e53 into googleapis:masterFeb 22, 2017

dhermes deleted the give-datastore-gax branch February 22, 2017 00:48

dhermes mentioned this pull request Feb 24, 2017
Upgrading all versions for umbrella release. #3068
Merged
19 tasks

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Merge pull requestgoogleapis#3036from dhermes/give-datastore-gax
1580efe
Moving datastore GAX/gRPC helpers out of _http and into dedicated module.

theacodes unassigned daspecster Sep 28, 2018

parthea pushed a commit that referenced this pull request Nov 24, 2025
Merge pull request#3036from dhermes/give-datastore-gax
5444267
Moving datastore GAX/gRPC helpers out of _http and into dedicated module.

Uh oh!

Conversation

dhermes commented Feb 17, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Feb 17, 2017

Uh oh!

daspecster commented Feb 17, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants