Add gccl metrics header to Spanner. by lukesneeringer · Pull Request #3045 · googleapis/google-cloud-python

lukesneeringer · 2017-02-21T17:25:09Z

This PR adds the gccl/x.y.z portion of the metrics header in the Spanner client library.

Sign in to view

 class _Client(object):
- pass
+ def __init__(self, *args, **kwargs):
+ pass


Sign in to view

 class _Client(object):
- pass
+ def __init__(self, *args, **kwargs):
+ pass


tseaver · 2017-02-21T17:41:37Z

The PR should also be rebased against current master to get rid of the spurious commits.

Sign in to view



+import pkg_resources
+__version__ = pkg_resources.get_distribution('google-cloud-spanner').version


Sign in to view

 if self._spanner_api is None:
- self._spanner_api = SpannerClient()
+ self._spanner_api = SpannerClient(lib_name='gccl',
+ lib_version=__version__)


Sign in to view

 setup(
 name='google-cloud-spanner',
- version='0.23.1',
+ version='0.23.2',


Sign in to view

+ def test_admin_api_lib_name(self):
+ """Establish that the lib_name and lib_version are passed to
+ the database and instance API objects in the GAPIC.
+ """


Sign in to view

- pass
+ def __init__(self, *args, **kwargs):
+ self.args = args
+ self.kwargs = kwargs


Sign in to view

 expected_scopes = None
 self._constructor_test_helper(expected_scopes, creds)

+ def test_admin_api_lib_name(self):


lukesneeringer · 2017-02-21T21:27:28Z

Travis seems to be hung? Anyone know if I can do anything about this?

daspecster · 2017-02-21T21:37:02Z

@lukesneeringer there isn't anything you can do about Travis AFAICT. CircleCI should have covered it though so you should be clear to merge anyway in this case.

lukesneeringer · 2017-02-21T22:38:40Z

Okay, merging once @tseaver gives assent.

Sign in to view


- def _mock_spanner_client():
+ def _mock_spanner_client(*args, **kwargs):
+ self.assertIsInstance(args, (list, tuple))


dhermes · 2017-02-22T00:44:05Z

LGTM

tseaver · 2017-02-22T15:31:01Z

@lukesneeringer FWIW, your docstring-in-a-testcase here will be literally the only one in the whole codebase. If you feel that strongly about it, go ahead and merge.

lukesneeringer · 2017-02-22T15:35:55Z

I went ahead and removed it.

…-docs-samples#3045)

lukesneeringer self-assigned this Feb 21, 2017

lukesneeringer requested a review from dhermes February 21, 2017 17:25

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2017

lukesneeringer added the api: spanner Issues related to the Spanner API. label Feb 21, 2017

tseaver suggested changes Feb 21, 2017
View reviewed changes

Luke Sneeringer added 2 commits February 21, 2017 09:44

Add 'gccl' metrics header to Spanner client library.
f24256a

Bump version to 0.23.2.
92ac894

lukesneeringer force-pushed the spanner-gccl branch from 1f06db0 to a8169f2Compare February 21, 2017 17:47

dhermes reviewed Feb 21, 2017
View reviewed changes

Address feedback and CI issues.
87b2c55

lukesneeringer force-pushed the spanner-gccl branch from ad8590a to 87b2c55Compare February 21, 2017 20:39

dhermes reviewed Feb 22, 2017
View reviewed changes

Comment threadspanner/unit_tests/test_database.py Outdated

def _mock_spanner_client():
def _mock_spanner_client(*args, **kwargs):
self.assertIsInstance(args, (list, tuple))
This comment was marked as spam.
Sign in to view

Luke Sneeringer added 2 commits February 22, 2017 07:31

*args is always a tuple.
4839c12

Remove test docstring.
5039a6e

lukesneeringer merged commit 5e80776 into googleapis:masterFeb 22, 2017

lukesneeringer deleted the spanner-gccl branch February 22, 2017 16:22

lukesneeringer mentioned this pull request Feb 22, 2017
GAX headers #3049
Closed
7 tasks

dhermes mentioned this pull request Feb 24, 2017
Upgrading all versions for umbrella release. #3068
Merged
19 tasks

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Add gccl metrics header to Spanner. (googleapis#3045)
7851c8d

parthea pushed a commit that referenced this pull request Oct 21, 2023
automl: move samples to beta set [(#3045)](GoogleCloudPlatform/python…
3451a62
…-docs-samples#3045)

parthea pushed a commit that referenced this pull request Mar 9, 2026
Add gccl metrics header to Spanner. (#3045)
e846bdf



		import pkg_resources
		__version__ = pkg_resources.get_distribution('google-cloud-spanner').version

Uh oh!

Conversation

lukesneeringer commented Feb 21, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Feb 21, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

lukesneeringer commented Feb 21, 2017

Uh oh!

daspecster commented Feb 21, 2017

Uh oh!

lukesneeringer commented Feb 21, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Feb 22, 2017

Uh oh!

tseaver commented Feb 22, 2017

Uh oh!

lukesneeringer commented Feb 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants