Skip to content

GAPIC Header Consistency: Pubsub - #3052

Merged
lukesneeringer merged 2 commits into
googleapis:masterfrom
lukesneeringer:gccl-pubsub
Feb 23, 2017
Merged

GAPIC Header Consistency: Pubsub#3052
lukesneeringer merged 2 commits into
googleapis:masterfrom
lukesneeringer:gccl-pubsub

Conversation

@lukesneeringer

Copy link
Copy Markdown
Contributor

No description provided.

@lukesneeringerlukesneeringer added the api: pubsub Issues related to the Pub/Sub API. label Feb 22, 2017
@lukesneeringerlukesneeringer self-assigned this Feb 22, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2017
@lukesneeringerlukesneeringer mentioned this pull request Feb 22, 2017
7 tasks
Comment threadpubsub/unit_tests/test__gax.py Outdated

from google.cloud._testing import _GAXBaseAPI

from google.cloud.pubsub import __version__

This comment was marked as spam.

This comment was marked as spam.

Comment threadpubsub/unit_tests/test__gax.py Outdated
def mock_publisher_api(channel):
def mock_publisher_api(channel, **kwargs):
channels.append(channel)
publisher_api_kwargs.update(kwargs)

This comment was marked as spam.

@lukesneeringer

Copy link
Copy Markdown
ContributorAuthor

@dhermes Can I consider this one to be approved?

@lukesneeringer
lukesneeringer merged commit dae40f9 into googleapis:masterFeb 23, 2017
@lukesneeringer
lukesneeringer deleted the gccl-pubsub branch February 23, 2017 16:50
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
parthea pushed a commit that referenced this pull request Mar 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lukesneeringer@tseaver@dhermes@googlebot