Skip to content

Making datastore Connection.commit() return low-level protobuf. - #3064

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-2746-commit
Feb 24, 2017
Merged

Making datastore Connection.commit() return low-level protobuf.#3064
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-2746-commit

Conversation

@dhermes

@dhermesdhermes commented Feb 23, 2017

Copy link
Copy Markdown
Contributor

Towards #2746. This approach is to slowly transition from our current approach to use the GAPIC generated surface.

It is unfortunately tangled quite a bit (partly because we may have too much mocked in the tests).

@dhermesdhermes added the api: datastore Issues related to the Datastore API. label Feb 23, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 23, 2017
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Feb 24, 2017
@dhermes
Making datastore Connection.run_query() return low-level protobuf.
fefb299
Towards googleapis#2746 (as is googleapis#3064). This approach is to slowly transition
from our current approach to use the GAPIC generated surface.
These unit tests weren't so bad to update. I did "editorialize"
as I went, downgrading constants to just variables, renamining
for PEP8, etc.
@dhermesdhermes mentioned this pull request Feb 24, 2017
Merged
@tseaver

tseaver commented Feb 24, 2017

Copy link
Copy Markdown
Contributor

@dhermes so this is preparatory to adding google.cloud.datastore._gax, with its own implemenation of the API via the GAPIC client?

@lukesneeringer

lukesneeringer commented Feb 24, 2017

Copy link
Copy Markdown
Contributor

@dhermes Is your goal to get this in with the umbrella releaase, or after?

daspecster
daspecster reviewed Feb 24, 2017
View reviewed changes
Comment threaddatastore/google/cloud/datastore/batch.py
:class:`.entity_pb2.Key` for each incomplete key
that was completed in the commit.
"""
mut_results = commit_response_pb.mutation_results

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threaddatastore/unit_tests/test_batch.py
]
response = datastore_pb2.CommitResponse(
mutation_results=[
datastore_pb2.MutationResult(key=key) for key in keys

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lukesneeringer

lukesneeringer commented Feb 24, 2017

Copy link
Copy Markdown
Contributor

Approved, but holding off on merge until the umbrella release question is answered.

@dhermes

dhermes commented Feb 24, 2017

Copy link
Copy Markdown
ContributorAuthor

@lukesneeringer A merge is just fine.

@tseavergoogle.cloud.datastore._gax already exists, but yes this is part of the transition to switch to using the GAPIC layer in google.cloud.datastore._gax.

@dhermes
Making datastore Connection.commit() return low-level protobuf.
9488e3c
Towards googleapis#2746. This approach is to slowly transition from our
current approach to use the GAPIC generated surface.
It is unfortunately tangled quite a bit (partly because we
may have too much mocked in the tests).
@dhermes

dhermes commented Feb 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Passing on Travis, not done yet on CircleCI (since it doesn't yet do a restricted set of tests). Merging before CircleCI is done.

@dhermes
dhermes merged commit 4d2b91d into googleapis:masterFeb 24, 2017
@dhermes
dhermes deleted the fix-2746-commit branch February 24, 2017 18:08
This was referenced Feb 24, 2017
Merged
Closed
Merged
Merged
Merged
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Making datastore Connection.run_query() return low-level protobuf.
222d08c
Towards googleapis#2746 (as is googleapis#3064). This approach is to slowly transition
from our current approach to use the GAPIC generated surface.
These unit tests weren't so bad to update. I did "editorialize"
as I went, downgrading constants to just variables, renamining
for PEP8, etc.
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull requestgoogleapis#3064from dhermes/fix-2746-commit
78f92db
Making datastore Connection.commit() return low-level protobuf.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Making datastore Connection.run_query() return low-level protobuf.
449c52c
Towards #2746 (as is #3064). This approach is to slowly transition
from our current approach to use the GAPIC generated surface.
These unit tests weren't so bad to update. I did "editorialize"
as I went, downgrading constants to just variables, renamining
for PEP8, etc.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Merge pull request#3064from dhermes/fix-2746-commit
978dcff
Making datastore Connection.commit() return low-level protobuf.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@daspecsterdaspecsterdaspecster left review comments
@lukesneeringerlukesneeringerlukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

@tseavertseaver

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes@tseaver@lukesneeringer@daspecster@googlebot