Skip to content

Add system test for insert/fetch of rows w/ nested schema. - #3140

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:3029-bigquery-systest-insert-fetch-w-complex-schema
Mar 21, 2017
Merged

Add system test for insert/fetch of rows w/ nested schema.#3140
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:3029-bigquery-systest-insert-fetch-w-complex-schema

Conversation

@tseaver

@tseavertseaver commented Mar 14, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Uses #3118 as a base.

Derived from schema / data from @tswast.

Toward #3029.

@tseavertseaver added api: bigquery Issues related to the BigQuery API. testing labels Mar 14, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2017
@daspecster

daspecster commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

@tseaver should be able to merge #3118 and rebase this off master.

Also, there's a lint error in this branch just FYI.

@tseavertseaver mentioned this pull request Mar 15, 2017
Merged
@tseaver

tseaver commented Mar 15, 2017

Copy link
Copy Markdown
ContributorAuthor

@daspecster, @dhermes Any issues?

dhermes
dhermes reviewed Mar 15, 2017
View reviewed changes
Comment threadsystem_tests/bigquery.py
self.assertEqual(len(fetched), len(to_insert))

for found, expected in zip(sorted(fetched), sorted(to_insert)):
self.assertEqual(found[0], expected[0]) # Name

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadsystem_tests/bigquery.py

for found, expected in zip(sorted(fetched), sorted(to_insert)):
self.assertEqual(found[0], expected[0]) # Name
self.assertEqual(found[1], int(expected[1])) # Age

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadsystem_tests/bigquery.py

e_icon = base64.standard_b64decode(
e_spell['Icon'].encode('ascii'))
self.assertEqual(f_spell['Icon'], e_icon)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadsystem_tests/bigquery_test_data.json
@@ -0,0 +1,66 @@
[

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseavertseaver mentioned this pull request Mar 20, 2017
Closed
@tseaver

tseaver commented Mar 20, 2017

Copy link
Copy Markdown
ContributorAuthor

@dhermes I think I answered your questions.

@tseaver

tseaver commented Mar 21, 2017

Copy link
Copy Markdown
ContributorAuthor

@dhermes, @lukesneeringer, @daspecster Any remaining issues?

@lukesneeringer

lukesneeringer commented Mar 21, 2017

Copy link
Copy Markdown
Contributor

None from me. :-)

@tseaver
tseaver merged commit 983783b into googleapis:masterMar 21, 2017
@tseaver
tseaver deleted the 3029-bigquery-systest-insert-fetch-w-complex-schema branch March 21, 2017 16:55
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@tseaver
Merge pull requestgoogleapis#3140from tseaver/3029-bigquery-systest…
3a8ba72
…-insert-fetch-w-complex-schema
Add system test for insert/fetch of rows w/ nested schema.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daspecsterdaspecsterAwaiting requested review from daspecster
2 more reviewers
@dhermesdhermesdhermes left review comments
@lukesneeringerlukesneeringerlukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tseaver@daspecster@lukesneeringer@dhermes@googlebot