Implementing storage regression tests to match gcloud-node. by dhermes · Pull Request #319 · googleapis/google-cloud-python

dhermes · 2014-10-31T05:32:51Z

Not meant to be merged. Some missing features were
uncovered or hard to use APIs and I want to discuss here
and then map out the plan (i.e. how to break this up).

coveralls · 2014-10-31T05:35:58Z

Changes Unknown when pulling bdd28b6 on dhermes:storage-regression-tests into * on GoogleCloudPlatform:master*.

coveralls · 2014-10-31T20:34:48Z

Coverage remained the same when pulling 7185cb8 on dhermes:storage-regression-tests into 8e12e10 on GoogleCloudPlatform:master.

coveralls · 2014-10-31T23:23:02Z

Coverage remained the same when pulling 501bbe0 on dhermes:storage-regression-tests into 26d7eef on GoogleCloudPlatform:master.

dhermes · 2014-11-01T08:25:49Z

@tseaver or @silvolu, any comments on this?

coveralls · 2014-11-01T08:28:12Z

Coverage remained the same when pulling 4211f38 on dhermes:storage-regression-tests into 632e126 on GoogleCloudPlatform:master.

Sign in to view

coveralls · 2014-11-03T21:51:06Z

Coverage remained the same when pulling fb3b3ba on dhermes:storage-regression-tests into f33e557 on GoogleCloudPlatform:master.

Sign in to view

coveralls · 2014-11-03T22:38:26Z

Coverage remained the same when pulling 7f32773 on dhermes:storage-regression-tests into 2b73c7b on GoogleCloudPlatform:master.

coveralls · 2014-11-04T18:26:45Z

Coverage remained the same when pulling b48ce7a on dhermes:storage-regression-tests into abe3d7c on GoogleCloudPlatform:master.

coveralls · 2014-11-04T18:44:14Z

Coverage remained the same when pulling c9f948d on dhermes:storage-regression-tests into a410c6a on GoogleCloudPlatform:master.

Note meant to be merged. Some missing features were uncovered or hard to use APIs and I want to discuss here and then map out the plan (i.e. how to break this up).

coveralls · 2014-11-04T22:35:06Z

Coverage remained the same when pulling 16c5ad9 on dhermes:storage-regression-tests into 826ea69 on GoogleCloudPlatform:master.

dhermes · 2014-11-05T04:16:03Z

@tseaver This has been rebased on top of #332, PTAL.

I have yet to change the edit to Bucket.upload_file (where the Key is returned), but I can pursue the approach we discussed of constructing the key in the test.

tseaver · 2014-11-05T05:22:43Z

Ugh, I've lost the thread now of what I meant. I'd say go ahead and land it, and we'll work it out later if it comes clear.

Source-Link: googleapis/synthtool@6ed3a83 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

fix(deps): require proto-plus >= 1.22.0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@59171c8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2ed982f884312e4883e01b5ab8af8b6935f0216a5a2d82928d273081fc3be562 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:c66ba3c8d7bc8566f47df841f98cd0097b28fff0b1864c86f5817f4c8c3e8600

Minor surface tweaks from issues uncovered while generating GAPICs.

* fix: bring back ModuleNotFoundError handler in pandas_backports.py * add unit-test for import_default functions

@chalmerlowe

* feat: Adds Python 3.13 support * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix(kokoro): Preserve NOX_SESSION in presubmit.cfg * Apply suggestion from @chalmerlowe * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix(kokoro): Update path to presubmit.cfg in owlbot.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Apply suggestion from @chalmerlowe * Apply suggestion from @chalmerlowe * Update owlbot.py * Update .kokoro/presubmit/presubmit.cfg * updates owlbot.py and noxfile.py to use 3.10 for system and linting. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * updates owlbot.py to try to account for system test * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Apply suggestion from @chalmerlowe * Apply suggestion from @chalmerlowe * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Apply suggestion from @chalmerlowe * Apply suggestion from @chalmerlowe * Apply suggestion from @chalmerlowe * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Apply suggestion from @chalmerlowe * Apply suggestion from @chalmerlowe * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Apply suggestion from @chalmerlowe * updates lint version to match default of 3.10 * updates system test version to match default of 3.10 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * updates lint version to match default of 3.10 redux * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * modified the owlbot to take advantage of a capability in common.py_library * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.36.0](googleapis/python-dns@v0.35.1...v0.36.0) (2025-11-05) ### Features * Add support for Python 3.14 ([#321](googleapis/python-dns#321)) ([99c0adb](googleapis/python-dns@99c0adb)) * Adds Python 3.13 support ([#319](googleapis/python-dns#319)) ([ea851ce](googleapis/python-dns@ea851ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: manual synth * ran synthtool to add bundle proto definitions * beginning of bundle implementation added methods to assemble bundles, but not yet serialize them into length-prefixed json strings with tests for bundle assembly * linting * Added bundle build method * fixed incomplete document id * fixed git merge error * Added first draft of docstrings * Added FirestoreBundle deserialization * Fixed import desync * Improved test coverage for bundles * linting * test coverage * CI happiness * converted redundant exception to assertion * removed todo * Updated comments * linted * Moved query limit type into bundle code * Added typed response for parsing reference values * refactored document reference parsing * removed auto import of bundles from firestore * small tweaks * added tests for document iters * Updated FirestoreBundle imports and synthtool gen * linting * extra test coverage * responses to code review * linting * Fixed stale docstring * camelCased bundle output * updated stale comments * Added test for binary data * linting Co-authored-by: Craig Labenz <craiglabenz@google.com> Co-authored-by: Christopher Wilcox <crwilcox@google.com>

This PR puts the `version` under the right header. and adds the missing info in pyproject.toml

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e601da6e29c993e14c52867f2c088dfb841beae618d2a4f1e0f7970a888ab020 <details><summary>google-crc32c: 1.8.0</summary> ## [1.8.0](googleapis/python-crc32c@v1.7.1...v1.8.0) (2025-12-15) ### Features * support Python 3.14 (#315) ([49d0a36f](googleapis/python-crc32c@49d0a36f)) ### Bug Fixes * update toml file with setup.cfg content (#319) ([42e5268c](googleapis/python-crc32c@42e5268c)) </details>

🤖 I have created a release *beep* *boop* --- ## [1.8.0](googleapis/python-crc32c@v1.7.1...v1.8.0) (2025-12-15) ### Features * Support Python 3.14 ([#315](googleapis/python-crc32c#315)) ([49d0a36](googleapis/python-crc32c@49d0a36)) ### Bug Fixes * Update toml file with setup.cfg content ([#319](googleapis/python-crc32c#319)) ([42e5268](googleapis/python-crc32c@42e5268)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Fixes#319 - [x] Tests pass - [x] Appropriate changes to README are included in PR

…326) Explicit 'encoding' overrides the fallback. Use the 'charset' param of 'content_type', rather than 'content_encoding', which isn't going to be a Unicode -> bytes encoding. Closes#319. Also, rewrap long param descriptions for in-source readability.

This PR migrates from autosynth to [owl bot](https://github.com/googleapis/repo-automation-bots/tree/master/packages/owl-bot). owl bot will save time for maintainers as it will automatically open PRs when there are updates in [googleapis-gen](https://github.com/googleapis/googleapis-gen/tree/master/google) without requiring maintainers to run `synthtool` to build the client from protos. Additionally, similar to autosynth, PRs will be automatically opened when there are template updates. With owl bot, on every PR, a post-processor image will run so that we won't have to ask contributors to run [blacken](https://github.com/googleapis/python-spanner/blob/master/synth.py#L88).

There is [an issue](https://github.com/googleapis/python-spanner/blob/master/owlbot.py#L30) in the `owlbot.py` file added in #319 in that [s.remove_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L309) should only be called once after all the files are copied over. [get_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L280) will only return staging directories that exist.

🤖 I have created a release *beep* *boop* --- ## [2.0.6](https://togithub.com/googleapis/sphinx-docfx-yaml/compare/v2.0.5...v2.0.6) (2023-10-30) ### Bug Fixes * Refactor type hint retrieval ([#312](https://togithub.com/googleapis/sphinx-docfx-yaml/issues/312)) ([0c91f60](https://togithub.com/googleapis/sphinx-docfx-yaml/commit/0c91f60fb2eab8b184b1228d5f3eb133be7ae201)) * Support docstrings without type added ([#311](https://togithub.com/googleapis/sphinx-docfx-yaml/issues/311)) ([d214d64](https://togithub.com/googleapis/sphinx-docfx-yaml/commit/d214d64c54d06fa715535b14932ac1ad67fa0d09)) * Update annotation name extraction logic and add unit tests ([#320](https://togithub.com/googleapis/sphinx-docfx-yaml/issues/320)) ([220951d](https://togithub.com/googleapis/sphinx-docfx-yaml/commit/220951d341c27d345679f64fb67968320168e428)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

This PR puts the `version` under the right header. and adds the missing info in pyproject.toml

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e601da6e29c993e14c52867f2c088dfb841beae618d2a4f1e0f7970a888ab020 <details><summary>google-crc32c: 1.8.0</summary> ## [1.8.0](googleapis/python-crc32c@v1.7.1...v1.8.0) (2025-12-15) ### Features * support Python 3.14 (#315) ([49d0a36f](googleapis/python-crc32c@49d0a36f)) ### Bug Fixes * update toml file with setup.cfg content (#319) ([42e5268c](googleapis/python-crc32c@42e5268c)) </details>

🤖 I have created a release *beep* *boop* --- ## [1.8.0](googleapis/python-crc32c@v1.7.1...v1.8.0) (2025-12-15) ### Features * Support Python 3.14 ([#315](googleapis/python-crc32c#315)) ([49d0a36](googleapis/python-crc32c@49d0a36)) ### Bug Fixes * Update toml file with setup.cfg content ([#319](googleapis/python-crc32c#319)) ([42e5268](googleapis/python-crc32c@42e5268)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

dhermes added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: storage Issues related to the Cloud Storage API. testing labels Oct 31, 2014

dhermes force-pushed the storage-regression-tests branch from bdd28b6 to 7185cb8Compare October 31, 2014 20:30

dhermes force-pushed the storage-regression-tests branch from 7185cb8 to 501bbe0Compare October 31, 2014 23:18

dhermes force-pushed the storage-regression-tests branch from 501bbe0 to 4211f38Compare November 1, 2014 08:25

tseaver reviewed Nov 3, 2014
View reviewed changes

Comment threadgcloud/storage/bucket.py Outdated
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

dhermes force-pushed the storage-regression-tests branch from 4211f38 to fb3b3baCompare November 3, 2014 21:38

dhermes reviewed Nov 3, 2014
View reviewed changes

Comment threadgcloud/storage/bucket.py Outdated
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

dhermes mentioned this pull request Nov 3, 2014
Adding extra parameters for querying Cloud Storage keys. #332
Merged

dhermes force-pushed the storage-regression-tests branch from fb3b3ba to 7f32773Compare November 3, 2014 22:31

dhermes mentioned this pull request Nov 4, 2014
Smooth out API surfaces before M1 #336
Closed

dhermes force-pushed the storage-regression-tests branch from 7f32773 to b48ce7aCompare November 4, 2014 18:18

dhermes force-pushed the storage-regression-tests branch from b48ce7a to c9f948dCompare November 4, 2014 18:36

Implementing storage regression tests to match gcloud-node.
16c5ad9
Note meant to be merged. Some missing features were uncovered or hard to use APIs and I want to discuss here and then map out the plan (i.e. how to break this up).

dhermes force-pushed the storage-regression-tests branch from c9f948d to 16c5ad9Compare November 4, 2014 22:29

parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(main): release 2.6.0 (#319)
d1baca2
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Oct 21, 2023
fix(deps): allow protobuf < 5.0.0 (#319)
b0c477f
fix(deps): require proto-plus >= 1.22.0

parthea pushed a commit that referenced this pull request Oct 22, 2023
chore(main): release 1.11.2 (#319)
7504f58
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 22, 2025
chore: new owl bot post processor docker image (#319)
02d8445
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:c66ba3c8d7bc8566f47df841f98cd0097b28fff0b1864c86f5817f4c8c3e8600

parthea pushed a commit that referenced this pull request Nov 24, 2025
Gapic tweaks (#319)
c4c296d
Minor surface tweaks from issues uncovered while generating GAPICs.

parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(main): release 1.2.0 (#319)
2bb1842

parthea pushed a commit that referenced this pull request Nov 24, 2025
docs: fix changelog header to consistent size (#319)
e89e301

parthea pushed a commit that referenced this pull request Nov 24, 2025
chore: Update some dependencies (#319)
a816812

parthea pushed a commit that referenced this pull request Nov 24, 2025
docs: fix changelog header to consistent size (#319)
f41882c

parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: Re-add ModuleNotFoundError handler for pandas_backports (#319)
40844e9
* fix: bring back ModuleNotFoundError handler in pandas_backports.py * add unit-test for import_default functions

parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(main): release 0.13.5-alpha (#319)
02ca614
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: structured log handler formatting issues (#319)
3cc9632

parthea pushed a commit that referenced this pull request Nov 25, 2025
fix: structured log handler formatting issues (#319)
1f5982f

parthea pushed a commit that referenced this pull request Mar 2, 2026
fix: update toml file with setup.cfg content (#319)
79781ba
This PR puts the `version` under the right header. and adds the missing info in pyproject.toml

parthea pushed a commit that referenced this pull request Mar 2, 2026
fix: retry client side requests timeout (#319)
787baa7

parthea pushed a commit that referenced this pull request Mar 9, 2026
fix: Fix check so it's all lowercase. (#321)
0cb7311
Fixes#319 - [x] Tests pass - [x] Appropriate changes to README are included in PR

ohmayr added a commit that referenced this pull request Mar 31, 2026
fix: update toml file with setup.cfg content (#319)
fc7a97f
This PR puts the `version` under the right header. and adds the missing info in pyproject.toml

Uh oh!

Conversation

dhermes commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

dhermes commented Nov 1, 2014

Uh oh!

coveralls commented Nov 1, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 3, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 3, 2014

Uh oh!

coveralls commented Nov 4, 2014

Uh oh!

coveralls commented Nov 4, 2014

Uh oh!

coveralls commented Nov 4, 2014

Uh oh!

dhermes commented Nov 5, 2014

Uh oh!

tseaver commented Nov 5, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants