Skip to content

Make clients explicitly unpickleable. - #3230

Merged
lukesneeringer merged 4 commits into
googleapis:masterfrom
lukesneeringer:issue-3211
Mar 30, 2017
Merged

Make clients explicitly unpickleable.#3230
lukesneeringer merged 4 commits into
googleapis:masterfrom
lukesneeringer:issue-3211

Conversation

@lukesneeringer

@lukesneeringerlukesneeringer commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

Closes#3211.

@lukesneeringerlukesneeringer self-assigned this Mar 28, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2017
lukesneeringer
lukesneeringer commented Mar 28, 2017
View reviewed changes
Comment threadcore/google/cloud/client.py

"""Base classes for client used to interact with Google Cloud APIs."""

from pickle import PicklingError

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes approved these changes Mar 28, 2017
View reviewed changes

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM. Style nit in the string creation. (I would say it's a "teeny performance hit" to create a new string at every use, but that would be wrong since the string is created right before program exit.)

Comment threadcore/google/cloud/client.py

"""Base classes for client used to interact with Google Cloud APIs."""

from pickle import PicklingError

This comment was marked as spam.

Sign in to view

Comment threadcore/google/cloud/client.py Outdated

def __getstate__(self):
"""Explicitly state that clients are not pickleable."""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadcore/google/cloud/client.py
raise PicklingError('\n'.join([
'Pickling client objects is explicitly not supported.',
'Clients have non-trivial state that is local and unpickleable.',
]))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lukesneeringer

lukesneeringer commented Mar 28, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I would say it's a "teeny performance hit" to create a new string at every use, but that would be wrong since the string is created right before program exit.

The teeny performance hit would be to create a new string at module import for everyone else.

@dhermes

dhermes commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

Feel free to merge once you get CI green

@lukesneeringer
lukesneeringer merged commit 0faaf54 into googleapis:masterMar 30, 2017
@lukesneeringer
lukesneeringer deleted the issue-3211 branch March 30, 2017 14:51
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 30, 2017
@dhermes
Fixing usage of http= vs. _http= in core unit test.
be8632a
Issue caused by two unrelated PRs merging in close
proximity: googleapis#3235 and googleapis#3230.
@dhermesdhermes mentioned this pull request Mar 30, 2017
Merged
lukesneeringer pushed a commit that referenced this pull request Mar 30, 2017
@dhermes@lukesneeringer
Fixing usage of http= vs. _http= in core unit test. (#3243)
6b1475c
Issue caused by two unrelated PRs merging in close
proximity: #3235 and #3230.
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@lukesneeringer
Make clients explicitly unpickleable. (googleapis#3230)
26cfff9
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes@lukesneeringer
Fixing usage of http= vs. _http= in core unit test. (googleapis#3243)
9ded5f6
Issue caused by two unrelated PRs merging in close
proximity: googleapis#3235 and googleapis#3230.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@lukesneeringer
Make clients explicitly unpickleable. (#3230)
d388a18
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes@lukesneeringer
Fixing usage of http= vs. _http= in core unit test. (#3243)
f149074
Issue caused by two unrelated PRs merging in close
proximity: #3235 and #3230.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@theacodestheacodestheacodes approved these changes
@dhermesdhermesdhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukesneeringer@dhermes@theacodes@googlebot