GA and Beta Promotions by lukesneeringer · Pull Request #3245 · googleapis/google-cloud-python

lukesneeringer · 2017-03-30T16:32:33Z

Promoted to GA (1.0.0):

Datastore
Logging
Storage

Promoted to Beta (0.24.0):

Language
Translate

Everything else gets a bump to 0.24.0, but still alpha.

Sign in to view

+ raise PicklingError('\n'.join([
+ 'Pickling client objects is explicitly not supported.',
+ 'Clients have non-trivial state that is local and unpickleable.',
+ ]))


Sign in to view

 # General information about the project.
 project = u'google-cloud'
-copyright = u'2014, Google'
+copyright = u'2014-2017, Google'


Sign in to view


 REQUIREMENTS = [
- 'google-cloud-core >= 0.23.1, < 0.24dev',
+ 'google-cloud-core >= 0.24.1, < 0.25dev',


Sign in to view


 def __getstate__(self):
 """Explicitly state that clients are not pickleable."""
+


googlebot · 2017-03-30T17:00:17Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

Sign in to view

 'Programming Language :: Python :: 3',
 'Programming Language :: Python :: 3.4',
 'Programming Language :: Python :: 3.5',
+ 'Programming Language :: Python :: 3.6',


Sign in to view

 setup(
 name='google-cloud-bigquery',
- version='0.23.0',
+ version='0.24.0',


Sign in to view

 setup(
 name='google-cloud-core',
- version='0.23.1',
+ version='0.24.0',


Sign in to view


 REQUIREMENTS = [
- 'google-cloud-core >= 0.23.1, < 0.24dev',
+ 'google-cloud-core >= 0.24.1, < 0.25dev',


dhermes · 2017-03-30T17:14:55Z

@lukesneeringer There are two "manual" pieces to this release process as well:

Make a PR against our HappyBase repo
Update a gist that has a "mirror" package for google-cloud-language (called google-cloud-natural-language) I would really like a less manual process for this but haven't put the effort into figuring one out. (After these releases go out, I'll need to twine upload the new contents of this gist)

lukesneeringer · 2017-03-30T17:18:02Z

Great, thanks. I assume you are taking this on once CircleCI passes?

dhermes · 2017-03-30T17:22:20Z

@lukesneeringer Yes I am taking both of those on (once the pushes to PyPI occur, which will require us to push some tags first)

The latest build for this branch failed because lint tried to grab google-cloud-core from PyPI.

ISTM we need to add session.install('../core/') to our lint sessions?

dhermes · 2017-03-30T18:12:50Z

@lukesneeringer I had to push 84b8878 to depend on logging==1.0.0 in error_reporting's setup.py (was previously 0.24.0).

@tseaver @jonparrott What does a correct upper bound look like there? I went with

'google-cloud-logging >= 1.0.0, < 1.1dev',

theacodes · 2017-03-30T18:17:52Z

What does a correct upper bound look like there? I went with

That works for me.

dhermes · 2017-03-30T19:47:54Z

@daspecster I reverted #3241 and wrapped it into this PR. See my comment on that PR, but the failure seems to contradict your comments about returning a PB.

lukesneeringer · 2017-03-30T19:58:12Z

@tseaver @jonparrott What does a correct upper bound look like there? I went with

'google-cloud-logging >= 1.0.0, < 1.1dev',

I assert it should be google-cloud-logging >= 1.0.0, < 2.0dev

Closes#3211.

Done via "git grep '0\.24'" and "git grep '0\.23'".

This reverts commit 175a587.

dhermes · 2017-03-30T23:00:08Z

@lukesneeringer Do we want the https://github.com/GoogleCloudPlatform/google-cloud-python/tree/revert-3245-1.0 branch around still or was that an abandoned idea?

lukesneeringer · 2017-03-31T00:54:17Z

That was a button I clicked accidentally in GitHub. :-)

dhermes · 2017-03-31T19:28:22Z

The "off-build" versions have also been pushed (the 2nd one was manual):

asilversempirical · 2017-03-31T19:34:27Z

It looks like https://pypi.python.org/pypi/google-cloud-error-reporting was not pushed. Is that intentional, or is it just lagging behind?

dhermes · 2017-03-31T20:04:06Z

@asilversempirical (and @DizzeePascall) I am sorting out an issue with logging that is "by accident" blocking error-reporting since logging is a dependency of error-reporting. I hope to sort it out soon.

dhermes · 2017-04-01T02:09:24Z

error-reporting is finally going out (as 0.24.0) and will be pushed by this build:
https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/1575

Thanks for the patience!

pdknsk · 2017-04-07T23:08:39Z

I think storage got promoted to GA too early. Many features still missing. Like simultaneous uploading of both metadata and predefined ACLs. Or complete support for versioning.

lukesneeringer · 2017-04-10T03:35:04Z

GA does not entail feature completion; it simply entails a higher support level and commitment to try and avoid backwards-incompatible changes.

* Make clients explicitly unpickleable. Closesgoogleapis#3211. * Make clients explicitly unpickleable. Closesgoogleapis#3211. * Add GA designator, add 1.0 version numbers. * Version changes. Eep. * Oops, Speech is still alpha. * 0.24.0, not 0.24.1 * Remove double __getstate__ goof. * Version changes. Eep. * Oops, Speech is still alpha. * Remove double __getstate__ goof. * Adding 3.6 classifier where missing and fixing bad versions. Done via "git grep '0\.24'" and "git grep '0\.23'". * Fix Noxfiles forlocal packages. * Fixing copy-pasta issue in error reporting nox config. Also fixing bad indent in same file. * Depend on stable logging in error reporting package. * Fixing lint errors in error_reporting. These were masked because error_reporting's lint nox session was linting the datastore codebase. This also means that the error reporting package has gained __all__. * Fixing a syntax error in nox config for logging. Also fixing an indent error while I was in there. * Revert "Add docs for 'result_index' usage and a system test." This reverts commit b5742aa. * Fixing docs nox session for umbrella package. Two issues: - error_reporting came BEFORE logging (which means it would try to pull in a logging dep from PyPI that doesn't exist) - dns was NOT in the list of local packages * Updating upper bound on logging in error_reporting. * Un-revert typo fix.

* Make clients explicitly unpickleable. Closes#3211. * Make clients explicitly unpickleable. Closes#3211. * Add GA designator, add 1.0 version numbers. * Version changes. Eep. * Oops, Speech is still alpha. * 0.24.0, not 0.24.1 * Remove double __getstate__ goof. * Version changes. Eep. * Oops, Speech is still alpha. * Remove double __getstate__ goof. * Adding 3.6 classifier where missing and fixing bad versions. Done via "git grep '0\.24'" and "git grep '0\.23'". * Fix Noxfiles forlocal packages. * Fixing copy-pasta issue in error reporting nox config. Also fixing bad indent in same file. * Depend on stable logging in error reporting package. * Fixing lint errors in error_reporting. These were masked because error_reporting's lint nox session was linting the datastore codebase. This also means that the error reporting package has gained __all__. * Fixing a syntax error in nox config for logging. Also fixing an indent error while I was in there. * Revert "Add docs for 'result_index' usage and a system test." This reverts commit ea8d8d85da0af8720ee919313d61df626acb9103. * Fixing docs nox session for umbrella package. Two issues: - error_reporting came BEFORE logging (which means it would try to pull in a logging dep from PyPI that doesn't exist) - dns was NOT in the list of local packages * Updating upper bound on logging in error_reporting. * Un-revert typo fix.

* Make clients explicitly unpickleable. Closes#3211. * Make clients explicitly unpickleable. Closes#3211. * Add GA designator, add 1.0 version numbers. * Version changes. Eep. * Oops, Speech is still alpha. * 0.24.0, not 0.24.1 * Remove double __getstate__ goof. * Version changes. Eep. * Oops, Speech is still alpha. * Remove double __getstate__ goof. * Adding 3.6 classifier where missing and fixing bad versions. Done via "git grep '0\.24'" and "git grep '0\.23'". * Fix Noxfiles forlocal packages. * Fixing copy-pasta issue in error reporting nox config. Also fixing bad indent in same file. * Depend on stable logging in error reporting package. * Fixing lint errors in error_reporting. These were masked because error_reporting's lint nox session was linting the datastore codebase. This also means that the error reporting package has gained __all__. * Fixing a syntax error in nox config for logging. Also fixing an indent error while I was in there. * Revert "Add docs for 'result_index' usage and a system test." This reverts commit b5742aa. * Fixing docs nox session for umbrella package. Two issues: - error_reporting came BEFORE logging (which means it would try to pull in a logging dep from PyPI that doesn't exist) - dns was NOT in the list of local packages * Updating upper bound on logging in error_reporting. * Un-revert typo fix.

* Make clients explicitly unpickleable. Closes#3211. * Make clients explicitly unpickleable. Closes#3211. * Add GA designator, add 1.0 version numbers. * Version changes. Eep. * Oops, Speech is still alpha. * 0.24.0, not 0.24.1 * Remove double __getstate__ goof. * Version changes. Eep. * Oops, Speech is still alpha. * Remove double __getstate__ goof. * Adding 3.6 classifier where missing and fixing bad versions. Done via "git grep '0\.24'" and "git grep '0\.23'". * Fix Noxfiles forlocal packages. * Fixing copy-pasta issue in error reporting nox config. Also fixing bad indent in same file. * Depend on stable logging in error reporting package. * Fixing lint errors in error_reporting. These were masked because error_reporting's lint nox session was linting the datastore codebase. This also means that the error reporting package has gained __all__. * Fixing a syntax error in nox config for logging. Also fixing an indent error while I was in there. * Revert "Add docs for 'result_index' usage and a system test." This reverts commit ea8d8d85da0af8720ee919313d61df626acb9103. * Fixing docs nox session for umbrella package. Two issues: - error_reporting came BEFORE logging (which means it would try to pull in a logging dep from PyPI that doesn't exist) - dns was NOT in the list of local packages * Updating upper bound on logging in error_reporting. * Un-revert typo fix.

* Make clients explicitly unpickleable. Closes#3211. * Make clients explicitly unpickleable. Closes#3211. * Add GA designator, add 1.0 version numbers. * Version changes. Eep. * Oops, Speech is still alpha. * 0.24.0, not 0.24.1 * Remove double __getstate__ goof. * Version changes. Eep. * Oops, Speech is still alpha. * Remove double __getstate__ goof. * Adding 3.6 classifier where missing and fixing bad versions. Done via "git grep '0\.24'" and "git grep '0\.23'". * Fix Noxfiles forlocal packages. * Fixing copy-pasta issue in error reporting nox config. Also fixing bad indent in same file. * Depend on stable logging in error reporting package. * Fixing lint errors in error_reporting. These were masked because error_reporting's lint nox session was linting the datastore codebase. This also means that the error reporting package has gained __all__. * Fixing a syntax error in nox config for logging. Also fixing an indent error while I was in there. * Revert "Add docs for 'result_index' usage and a system test." This reverts commit b5742aa. * Fixing docs nox session for umbrella package. Two issues: - error_reporting came BEFORE logging (which means it would try to pull in a logging dep from PyPI that doesn't exist) - dns was NOT in the list of local packages * Updating upper bound on logging in error_reporting. * Un-revert typo fix.

lukesneeringer self-assigned this Mar 30, 2017

lukesneeringer requested a review from dhermes March 30, 2017 16:32

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2017

dhermes reviewed Mar 30, 2017
View reviewed changes

dhermes force-pushed the 1.0 branch from a711292 to 7a98dbcCompare March 30, 2017 16:56

dhermes reviewed Mar 30, 2017
View reviewed changes

Comment threadcore/google/cloud/client.py Outdated

def __getstate__(self):
"""Explicitly state that clients are not pickleable."""

This comment was marked as spam.
Sign in to view

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 30, 2017

dhermes reviewed Mar 30, 2017
View reviewed changes

dhermes mentioned this pull request Mar 30, 2017
google.cloud.error_reporting AttributeError: 'Client' object has no attribute '_project' #3233
Closed

Luke Sneeringerand others added 11 commits March 30, 2017 13:46

Make clients explicitly unpickleable.
966cb4d
Closes#3211.

Add GA designator, add 1.0 version numbers.
a4a8a92

Version changes. Eep.
3bf1c91

Oops, Speech is still alpha.
6f7776a

0.24.0, not 0.24.1
c01bfd9

Remove double __getstate__ goof.
42bf2e6

Make clients explicitly unpickleable.
1c7098d
Closes#3211.

Version changes. Eep.
592d500

Oops, Speech is still alpha.
e568b18

Remove double __getstate__ goof.
0209a1f

Adding 3.6 classifier where missing and fixing bad versions.
58c161a
Done via "git grep '0\.24'" and "git grep '0\.23'".

lukesneeringer merged commit 175a587 into masterMar 30, 2017

lukesneeringer deleted the 1.0 branch March 30, 2017 21:45

lukesneeringer added a commit that referenced this pull request Mar 30, 2017
Revert "GA and Beta Promotions (#3245)"
ff059ed
This reverts commit 175a587.


		def __getstate__(self):
		"""Explicitly state that clients are not pickleable."""

Uh oh!

Conversation

lukesneeringer commented Mar 30, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

googlebot commented Mar 30, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Mar 30, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukesneeringer commented Mar 30, 2017

Uh oh!

dhermes commented Mar 30, 2017

Uh oh!

dhermes commented Mar 30, 2017

Uh oh!

theacodes commented Mar 30, 2017

Uh oh!

dhermes commented Mar 30, 2017

Uh oh!

lukesneeringer commented Mar 30, 2017

Uh oh!

dhermes commented Mar 30, 2017

Uh oh!

lukesneeringer commented Mar 31, 2017

Uh oh!

dhermes commented Mar 31, 2017

Uh oh!

asilversempirical commented Mar 31, 2017

Uh oh!

dhermes commented Mar 31, 2017

Uh oh!

dhermes commented Apr 1, 2017

Uh oh!

pdknsk commented Apr 7, 2017

Uh oh!

lukesneeringer commented Apr 10, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lukesneeringer commented Mar 30, 2017•
edited
Loading

dhermes commented Mar 30, 2017•
edited
Loading

lukesneeringer commented Apr 10, 2017•
edited
Loading