Speech v1 by lukesneeringer · Pull Request #3266 · googleapis/google-cloud-python

lukesneeringer · 2017-04-03T17:45:23Z

This updates our manual client library to the Speech v1 API.

This entails several backwards incompatible changes:

The language_code parameter is no longer optional anywhere. It must be explicitly specified, and does not default to 'en-US'.
The sync_recognize method has been renamed to recognize on every class where it appears.
The async_recognize method has been renamed to long_running_recognize on every class where it appears.
The sample_rate parameter and property has been renamed to sample_rate_hertz everywhere it appears.

Additionally, the backend API contains a backwards incompatible change which does not require a code change in the client library, but will likely require one downstream: The START_OF_SPEECH, END_OF_SPEECH, and END_OF_AUDIO events have been removed.

Unit tests pass, need to check on system tests.

dhermes

Looks mostly OK. Lot's of cosmetic, not much content

Sign in to view

 profanity_filter=profanity_filter,
- speech_context=SpeechContext(phrases=speech_context))
+ sample_rate_hertz=sample.sample_rate_hertz,
+ speech_contexts=[SpeechContext(phrases=speech_contexts)],


Sign in to view


 def sample(self, content=None, source_uri=None, stream=None, encoding=None,
-sample_rate=None):
+sample_rate_hertz=None):


Sign in to view


 REQUIREMENTS = [
- 'google-cloud-core >= 0.24.0, < 0.25dev',
+ 'google-cloud-core >= 0.24.0, < 0.26dev',


Sign in to view

 setup(
 name='google-cloud-speech',
- version='0.24.0',
+ version='0.25.0',


Sign in to view

 """
+ # This bizarre delay is necessary because the v1 API seems to return
+ # the v1beta1 type URL sometimes if you poll too soon.
+ time.sleep(3)


…ud-python into speech-v1

dhermes · 2017-04-05T14:38:26Z

LGTM pending CI

lukesneeringer · 2017-04-05T15:20:25Z

@gguuss Are the samples ready for this? We are ready to push it out once your documentation is updated.

gguuss · 2017-04-05T20:15:48Z

I'll let y'all know when I have my change in a branch

gguuss · 2017-04-05T20:20:00Z

Sample changes staged here

theacodes · 2017-04-05T20:27:58Z

@lukesneeringer seems weird that the samples have to do speech_client.speech_api.x?

lukesneeringer · 2017-04-05T21:33:26Z

@jonparrott We do not. Those changes are red in the diff. :-)

lukesneeringer · 2017-04-06T14:24:56Z

@gguuss I am ready to push this to PyPI, as soon as you say you are ready.

lukesneeringer · 2017-04-07T14:40:19Z

@gguuss Poke. (This is due today, so I will push it to PyPI around noon regardless.)

gguuss · 2017-04-07T17:30:44Z

I'm ready to go.

nandoz · 2017-04-20T08:19:50Z

hello

This updates our manual client library to the Speech v1 API. This entails several **backwards incompatible changes**: * The `language_code` parameter is no longer optional anywhere. It must be explicitly specified, and does _not_ default to `'en-US'`. * The `sync_recognize` method has been renamed to `recognize` on every class where it appears. * The `async_recognize` method has been renamed to `long_running_recognize` on every class where it appears. * The `sample_rate` parameter and property has been renamed to `sample_rate_hertz` everywhere it appears. Additionally, the backend API contains a backwards incompatible change which does not require a code change in the client library, but will likely require one downstream: The `START_OF_SPEECH`, `END_OF_SPEECH`, and `END_OF_AUDIO` events have been removed.

…loudPlatform/python-docs-samples#3266) Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>

This updates our manual client library to the Speech v1 API. This entails several **backwards incompatible changes**: * The `language_code` parameter is no longer optional anywhere. It must be explicitly specified, and does _not_ default to `'en-US'`. * The `sync_recognize` method has been renamed to `recognize` on every class where it appears. * The `async_recognize` method has been renamed to `long_running_recognize` on every class where it appears. * The `sample_rate` parameter and property has been renamed to `sample_rate_hertz` everywhere it appears. Additionally, the backend API contains a backwards incompatible change which does not require a code change in the client library, but will likely require one downstream: The `START_OF_SPEECH`, `END_OF_SPEECH`, and `END_OF_AUDIO` events have been removed.

lukesneeringerand others added 4 commits April 2, 2017 13:44

[WIP] Speech v1
8454815

Speech v1 port.
67c1e65
Unit tests pass, need to check on system tests.

Fixed missing coverage; system tests still WIP.
7fb2b68

Fix to final bizarre system test. Raised with backend folks.
3dacda5

lukesneeringer self-assigned this Apr 3, 2017

lukesneeringer requested a review from dhermes April 3, 2017 17:45

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2017

dhermes reviewed Apr 3, 2017
View reviewed changes

lukesneeringerand others added 3 commits April 3, 2017 14:03

Update Speech docs.
f8b98b3

Change back version numbers.
d4d02ac

Merge branch 'speech-v1' of github.com:GoogleCloudPlatform/google-clo…
e8da4c0
…ud-python into speech-v1

lukesneeringer mentioned this pull request Apr 5, 2017
Remove time.sleep in Speech system tests. #3273
Closed

lukesneeringer merged commit a9268a3 into masterApr 5, 2017

lukesneeringer deleted the speech-v1 branch April 5, 2017 21:34

lukesneeringer mentioned this pull request Apr 7, 2017
Bump Speech to 0.25.0. #3280
Merged

parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(deps): update dependency cryptography to v2.9 [(#3266)](GoogleC…
fd3323d
…loudPlatform/python-docs-samples#3266) Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>

Uh oh!

Conversation

lukesneeringer commented Apr 3, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Apr 5, 2017

Uh oh!

lukesneeringer commented Apr 5, 2017

Uh oh!

gguuss commented Apr 5, 2017

Uh oh!

gguuss commented Apr 5, 2017

Uh oh!

theacodes commented Apr 5, 2017

Uh oh!

lukesneeringer commented Apr 5, 2017

Uh oh!

lukesneeringer commented Apr 6, 2017

Uh oh!

lukesneeringer commented Apr 7, 2017

Uh oh!

gguuss commented Apr 7, 2017

Uh oh!

nandoz commented Apr 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lukesneeringer commented Apr 3, 2017•
edited
Loading