Skip to content

Retry test - #3279

Closed
calpeyser wants to merge 3 commits into
googleapis:masterfrom
calpeyser:retry_test
Closed

Retry test#3279
calpeyser wants to merge 3 commits into
googleapis:masterfrom
calpeyser:retry_test

Conversation

@calpeyser

@calpeysercalpeyser commented Apr 6, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot

googlebot commented Apr 6, 2017

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebotgooglebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 6, 2017
@calpeysercalpeyser mentioned this pull request Apr 6, 2017
Closed
lukesneeringer
lukesneeringer suggested changes Apr 7, 2017
View reviewed changes

@lukesneeringerlukesneeringer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @calpeyser,
Thanks for submitting your PR. We are really grateful.

I have a few issues that I would appreciate if you could look into before I can merge. (Also, CI needs to pass.)

Thanks!

Comment threadbigtable/unit_tests/retry_server.go
@@ -0,0 +1,295 @@
package main

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadbigtable/google/cloud/bigtable/table.py
from google.cloud.bigtable.retry import ReadRowsIterator, _create_row_request
from grpc import StatusCode

BACKOFF_SETTINGS = BackoffSettings(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadbigtable/google/cloud/bigtable/table.py
# limitations under the License.

"""User friendly container for Google Cloud Bigtable Table."""
from __future__ import absolute_import, division

This comment was marked as spam.

Sign in to view

Comment threadbigtable/google/cloud/bigtable/retry.py
self.total_timeout = (retry_options.backoff_settings.total_timeout_millis / _MILLIS_PER_SECOND)
self.set_stream()

def set_start_key(self, start_key):

This comment was marked as spam.

Sign in to view

Comment threadbigtable/google/cloud/bigtable/retry.py
while deadline is None or now < deadline:
try:
return six.next(self.stream)
except StopIteration as stop:

This comment was marked as spam.

Sign in to view

Comment threadbigtable/google/cloud/bigtable/retry.py
return six.next(self.stream)
except StopIteration as stop:
raise stop
except Exception as exception: # pylint: disable=broad-except

This comment was marked as spam.

Sign in to view

Comment threadbigtable/google/cloud/bigtable/retry.py
except Exception as exception: # pylint: disable=broad-except
code = config.exc_to_code(exception)
if code not in self.retry_options.retry_codes:
raise errors.RetryError(

This comment was marked as spam.

Sign in to view

Comment threadbigtable/google/cloud/bigtable/retry.py
' classified as transient', exception)

# pylint: disable=redefined-variable-type
exc = errors.RetryError(

This comment was marked as spam.

Sign in to view

garye
garye suggested changes Apr 7, 2017
View reviewed changes

@garyegarye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

Comment threadbigtable/unit_tests/test_table.py
@@ -1,599 +0,0 @@
# Copyright 2015 Google Inc.

This comment was marked as spam.

Sign in to view

Comment threadbigtable/unit_tests/test_retry.py
def process_write(self, table, payload):
pass

def process_scan(self, table, range, ids):

This comment was marked as spam.

Sign in to view

Comment threadbigtable/unit_tests/test_retry.py
@@ -0,0 +1,54 @@
import unittest

This comment was marked as spam.

Sign in to view

Comment threadbigtable/unit_tests/retry_server.go
@@ -0,0 +1,295 @@
package main

This comment was marked as spam.

Sign in to view

Comment threadbigtable/google/cloud/bigtable/table.py
from google.cloud.bigtable.retry import ReadRowsIterator, _create_row_request
from grpc import StatusCode

BACKOFF_SETTINGS = BackoffSettings(

This comment was marked as spam.

Sign in to view

Comment threadbigtable/google/cloud/bigtable/row_data.py
self._validate_chunk(chunk)

if ("ReadRowsIterator" in self._response_iterator.__class__.__name__):
self._response_iterator.set_start_key(chunk.row_key)

This comment was marked as spam.

Sign in to view

@tseavertseaver added the api: bigtable Issues related to the Bigtable API. label Apr 18, 2017
@lukesneeringerlukesneeringer added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 19, 2017
@tseavertseaver mentioned this pull request May 15, 2017
Merged
@tseaver

tseaver commented May 15, 2017

Copy link
Copy Markdown
Contributor

Superseded by #3324

@tseavertseaver closed this May 15, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@lukesneeringerlukesneeringerlukesneeringer requested changes
@garyegaryegarye requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtableIssues related to the Bigtable API.cla: noThis human has *not* signed the Contributor License Agreement.priority: p2Moderately-important priority. Fix may not be included in next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@calpeyser@googlebot@tseaver@lukesneeringer@garye