Uh oh!
There was an error while loading. Please reload this page.
Set retain_acked_messages in seek system test - #3313
Closed
geigerj wants to merge 1 commit into
Closed
Conversation
This should prevent the (as of yet, unexperienced) error case where the API deletes the acked messages before we have a chance to seek to them.
dhermes
commented
Apr 19, 2017
Contributor
LGTM though I don't have great context for this. @geigerj Can we push this branch to the https://github.com/GoogleCloudPlatform/google-cloud-python remote so that system tests get run? |
geigerj
commented
Apr 19, 2017
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should prevent the (as of yet, unexperienced) error case where
the API deletes the acked messages before we have a chance to seek
to them.