Skip to content

Adding check (in datastore) that setup.py README is valid RST. - #3316

Merged
lukesneeringer merged 1 commit into
googleapis:masterfrom
dhermes:fix-2446-datastore
Apr 20, 2017
Merged

Adding check (in datastore) that setup.py README is valid RST.#3316
lukesneeringer merged 1 commit into
googleapis:masterfrom
dhermes:fix-2446-datastore

Conversation

@dhermes

@dhermesdhermes commented Apr 19, 2017

Copy link
Copy Markdown
Contributor

/cc @jonparrott

@lukesneeringer You mentioned that you'd prefer a standalone session for this. I am unclear why you prefer this. To me, checking that the README isn't invalid in setup.pyis linting.

@dhermesdhermes added api: datastore Issues related to the Datastore API. hygiene labels Apr 19, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2017
@lukesneeringerlukesneeringer added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 19, 2017
@lukesneeringer

lukesneeringer commented Apr 19, 2017

Copy link
Copy Markdown
Contributor

My rationale is:

  • These are separate and orthogonal checks. If one fails and one succeeds, I want to know that.
  • Different virtualenvs ensures atomicity.

@dhermes
dhermesforce-pushed the fix-2446-datastore branch from 51b7b03 to ec98ae7CompareApril 19, 2017 22:25
@dhermes

dhermes commented Apr 19, 2017

Copy link
Copy Markdown
ContributorAuthor

OK @lukesneeringer PTAL

@lukesneeringer
lukesneeringer merged commit 5d99380 into googleapis:masterApr 20, 2017
@lukesneeringerlukesneeringer removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 20, 2017
@dhermes
dhermes deleted the fix-2446-datastore branch April 20, 2017 16:34
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Apr 20, 2017
@dhermes
Adding check that **all** setup.py README's are valid RST.
7b1525f
Follow up to googleapis#3316. Fixesgoogleapis#2246.
@dhermesdhermes mentioned this pull request Apr 20, 2017
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Apr 20, 2017
@dhermes
Adding check that **all** setup.py README's are valid RST.
b66f17e
Follow up to googleapis#3316. Fixesgoogleapis#2446.
dhermes added a commit that referenced this pull request Apr 20, 2017
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
8a950b4
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
@dhermesdhermes mentioned this pull request Apr 27, 2017
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes@lukesneeringer
Adding check (in datastore) that setup.py README is valid RST. (googl…
8e73d35
…eapis#3316)
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Adding check that **all** setup.py README's are valid RST. (googleapi…
4c17230
…s#3318)
* Adding check that **all** setup.py README's are valid RST.
Follow up to googleapis#3316. Fixesgoogleapis#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
@tseavertseaver mentioned this pull request Jun 26, 2017
Merged
atulep pushed a commit that referenced this pull request Apr 3, 2023
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
38c2192
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
atulep pushed a commit that referenced this pull request Apr 18, 2023
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
fde87a5
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Jun 4, 2023
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
5a9f97a
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Jul 6, 2023
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
b50089c
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
8a712f6
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
ee1cc86
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
311a4e3
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Oct 22, 2023
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
3a008e3
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Nov 22, 2025
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
e6282c9
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
065ec4e
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
20eec54
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes@lukesneeringer
Adding check (in datastore) that setup.py README is valid RST. (#3316)
d26822b
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
b18224e
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
c980023
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
fe0063e
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Mar 2, 2026
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
4da4b4b
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Mar 9, 2026
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
77a74cb
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
parthea pushed a commit that referenced this pull request Mar 9, 2026
@dhermes
Adding check that **all** setup.py README's are valid RST. (#3318)
6a5a538
* Adding check that **all** setup.py README's are valid RST.
Follow up to #3316. Fixes#2446.
* Fixing duplicate reference in Logging README.
* Fixing duplicate reference in Monitoring README.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@lukesneeringerlukesneeringerlukesneeringer approved these changes
@theacodestheacodestheacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

@tseavertseaver

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes@lukesneeringer@theacodes@tseaver@googlebot