Skip to content

Pass client credentials through to instance / database admin API instances - #3326

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:3070-spanner-pass_explicit_creds_to_api_stubs
Apr 25, 2017
Merged

Pass client credentials through to instance / database admin API instances#3326
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:3070-spanner-pass_explicit_creds_to_api_stubs

Conversation

@tseaver

@tseavertseaver commented Apr 25, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#3070.

@tseavertseaver added api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release blocking Required feature/issue must be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 25, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2017
@tseavertseaver changed the title Pass client credentials through to instance / database admin API inst…Pass client credentials through to instance / database admin API instancesApr 25, 2017
@tseaver
tseaver merged commit b657337 into googleapis:masterApr 25, 2017
@tseaver
tseaver deleted the 3070-spanner-pass_explicit_creds_to_api_stubs branch April 25, 2017 19:47
@theacodestheacodes removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Apr 25, 2017
dhermes
dhermes reviewed Apr 25, 2017
View reviewed changes
Comment threadspanner/google/cloud/spanner/client.py
"""Helper for session-related API calls."""
if self._instance_admin_api is None:
self._instance_admin_api = InstanceAdminClient(
credentials=self.credentials,

This comment was marked as spam.

Sign in to view

@dhermesdhermes mentioned this pull request Apr 27, 2017
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@tseaver
Merge pull requestgoogleapis#3326from tseaver/3070-spanner-pass_exp…
4a37b62
…licit_creds_to_api_stubs
Pass client credentials through to instance / database admin API instances
parthea pushed a commit that referenced this pull request Mar 9, 2026
@tseaver
Merge pull request#3326from tseaver/3070-spanner-pass_explicit_cred…
5f033c3
…s_to_api_stubs
Pass client credentials through to instance / database admin API instances
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer
2 more reviewers
@dhermesdhermesdhermes left review comments
@theacodestheacodestheacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the Spanner API.cla: yesThis human has signed the Contributor License Agreement.release blockingRequired feature/issue must be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@theacodes@dhermes@googlebot