Skip to content

Adding retry to test_detect_web_images_from_gcs() system test. - #3339

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:flaky-vision-detect
May 9, 2017
Merged

Adding retry to test_detect_web_images_from_gcs() system test.#3339
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:flaky-vision-detect

Conversation

@dhermes

@dhermesdhermes commented Apr 27, 2017

Copy link
Copy Markdown
Contributor

@dhermesdhermes added api: vision Issues related to the Cloud Vision API. build testing labels Apr 27, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2017
dhermes
dhermes commented Apr 27, 2017
View reviewed changes
Comment threadvision/tests/system.py Outdated
web_images = image.detect_web(limit=limit)
self._assert_web_images(web_images, limit)

@RetryErrors(unittest.TestCase.failureException)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
dhermesforce-pushed the flaky-vision-detect branch from b232e3d to 03dbc40CompareMay 9, 2017 17:57
@dhermes

dhermes commented May 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@tseaver PTAL. I made the retry more focused (rather than retrying the entire test case).

@dhermes
dhermes merged commit 2980814 into googleapis:masterMay 9, 2017
@dhermes
dhermes deleted the flaky-vision-detect branch May 9, 2017 21:41
@tseavertseaver mentioned this pull request Jun 26, 2017
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@dhermes
Adding retry to test_detect_web_images_from_gcs() system test. (#3339)
2ad4ce8
Flaky in:
https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/1694
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

@tseavertseaver

Labels

api: visionIssues related to the Cloud Vision API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@tseaver@lukesneeringer@googlebot