Skip to content

Using binary streams for uploads in BigQuery system tests. - #3374

Merged
dhermes merged 1 commit into
masterfrom
fix-3371
May 5, 2017
Merged

Using binary streams for uploads in BigQuery system tests.#3374
dhermes merged 1 commit into
masterfrom
fix-3371

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Fixes#3371.

@dhermesdhermes added api: bigquery Issues related to the BigQuery API. build labels May 4, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2017
@dhermesdhermes added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed cla: yes This human has signed the Contributor License Agreement. labels May 4, 2017
@dhermes

Copy link
Copy Markdown
ContributorAuthor

CI failed because the logging build stalled out (a hard-to-repro issue we have yet to track down).

@lukesneeringer Why would logging even be running here?

Are we good to merge? (Note this branch is on the https://github.com/GoogleCloudPlatform/google-cloud-python/ remote, so the system tests have already run and passed for BigQuery.)

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2017
@dhermes
dhermes merged commit 9870057 into masterMay 5, 2017
@dhermes
dhermes deleted the fix-3371 branch May 5, 2017 22:42
@tseavertseaver mentioned this pull request Jun 26, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes@theacodes@lukesneeringer@tseaver@googlebot