Skip to content

Add back support for retries in storage uploads. - #3378

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:add-back-storage-retries2
May 10, 2017
Merged

Add back support for retries in storage uploads.#3378
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:add-back-storage-retries2

Conversation

@dhermes

@dhermesdhermes commented May 5, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@dhermesdhermes added the api: storage Issues related to the Cloud Storage API. label May 5, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2017
@dhermes

dhermes commented May 5, 2017

Copy link
Copy Markdown
ContributorAuthor

Was #3375

@dhermes

dhermes commented May 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@tseaver@lukesneeringer Can I get a review here?

tseaver
tseaver reviewed May 9, 2017
View reviewed changes
Comment threadstorage/google/cloud/storage/blob.py
bucket_path=self.bucket.path)
upload = MultipartUpload(upload_url, headers=headers)

if num_retries is not None:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadstorage/google/cloud/storage/blob.py
bucket_path=self.bucket.path)
upload = ResumableUpload(upload_url, chunk_size, headers=headers)

if num_retries is not None:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadstorage/tests/unit/test_blob.py

@mock.patch(u'google.resumable_media._upload.get_boundary',
return_value=b'==0==')
def test__do_multipart_upload_with_retry(self, mock_get_boundary):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
dhermes merged commit ff4f492 into googleapis:masterMay 10, 2017
@dhermes
dhermes deleted the add-back-storage-retries2 branch May 10, 2017 18:12
This was referenced Jun 26, 2017
Closed
Merged
@tswasttswast mentioned this pull request Nov 18, 2021
Closed
parthea pushed a commit that referenced this pull request Mar 9, 2026
@dhermes
Add back support for retries in storage uploads. (#3378)
4e6fb21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@tseavertseavertseaver left review comments
@lukesneeringerlukesneeringerlukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringerlukesneeringer

@tseavertseaver

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@lukesneeringer@tseaver@googlebot