Skip to content

Getters for row key and row table - #3408

Merged
dhermes merged 2 commits into
googleapis:masterfrom
CuriousDima:table-pr
May 12, 2017
Merged

Getters for row key and row table#3408
dhermes merged 2 commits into
googleapis:masterfrom
CuriousDima:table-pr

Conversation

@CuriousDima

Copy link
Copy Markdown
Contributor

Pulling out non-controversial part of #3401 for #2411.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2017
@dhermes

Copy link
Copy Markdown
Contributor

@skyfox This LGTM, I restarted your build, that failure seems spurious. Fingers crossed.

@dhermesdhermes added the api: bigtable Issues related to the Bigtable API. label May 12, 2017
@dhermes

Copy link
Copy Markdown
Contributor

@skyfox I manually rebased your branch onto the latest version of master (sorry if it caused any confusion).

@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebotgooglebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels May 12, 2017
@dhermes

Copy link
Copy Markdown
Contributor

@skyfox Some lines had trailing whitespace and it failed the lint part of the build. I sent a follow-up commit to your branch to resolve (sorry if that was not OK).

I have my editor configured to just strip any trailing whitespace from lines on save.

@dhermes
dhermes merged commit ecd4da4 into googleapis:masterMay 12, 2017
@CuriousDima

Copy link
Copy Markdown
ContributorAuthor

Thank you for merging!
Going to fix comments for the second part.

@CuriousDima
CuriousDima deleted the table-pr branch May 13, 2017 16:34
@tseavertseaver mentioned this pull request Jun 26, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: noThis human has *not* signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@CuriousDima@dhermes@googlebot